Skip to content

Enable redirect-based OAuth flow#127

Open
thepatrickchin wants to merge 5 commits intoNVIDIA:mainfrom
thepatrickchin:feat/redirect-auth
Open

Enable redirect-based OAuth flow#127
thepatrickchin wants to merge 5 commits intoNVIDIA:mainfrom
thepatrickchin:feat/redirect-auth

Conversation

@thepatrickchin
Copy link
Copy Markdown
Member

@thepatrickchin thepatrickchin commented Apr 2, 2026

Description

This is a complementary PR for NVIDIA/NeMo-Agent-Toolkit#1835
Closes NVIDIA/NeMo-Agent-Toolkit#1834

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
    • Any contribution which contains commits that are not Signed-Off will not be accepted.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

@thepatrickchin thepatrickchin requested a review from a team as a code owner April 2, 2026 06:09
@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot bot commented Apr 2, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@thepatrickchin thepatrickchin mentioned this pull request Apr 2, 2026
Open
@thepatrickchin
feat: add option to open OAuth login on same tab
79f5ba4 
Signed-off-by: Patrick Chin <8509935+thepatrickchin@users.noreply.github.com>
@thepatrickchin
feat: reconnect WS and resubmit message after returning from login
b77ad9c 
Signed-off-by: Patrick Chin <8509935+thepatrickchin@users.noreply.github.com>
@thepatrickchin
fix: display auth cancellation message when user clicks back
5c465ef 
Signed-off-by: Patrick Chin <8509935+thepatrickchin@users.noreply.github.com>
@thepatrickchin
feat: display cancellation reason
baf12c7 
Signed-off-by: Patrick Chin <8509935+thepatrickchin@users.noreply.github.com>
@thepatrickchin
refactor: rename use_popup_auth to use_redirect_auth and negate logic
0f48d00 
Signed-off-by: Patrick Chin <8509935+thepatrickchin@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add option to enable redirect-based OAuth flow

1 participant

@thepatrickchin