Decouple ATIF schemas from core and make nvidia-nat-eval lightweight by default#1833
Conversation
Signed-off-by: Anuradha Karuppiah <26330987+AnuradhaKaruppiah@users.noreply.github.com>
Signed-off-by: Anuradha Karuppiah <26330987+AnuradhaKaruppiah@users.noreply.github.com>
Signed-off-by: Anuradha Karuppiah <26330987+AnuradhaKaruppiah@users.noreply.github.com>
Signed-off-by: Anuradha Karuppiah <26330987+AnuradhaKaruppiah@users.noreply.github.com>
Signed-off-by: Anuradha Karuppiah <26330987+AnuradhaKaruppiah@users.noreply.github.com>
Signed-off-by: Anuradha Karuppiah <26330987+AnuradhaKaruppiah@users.noreply.github.com>
Signed-off-by: Anuradha Karuppiah <26330987+AnuradhaKaruppiah@users.noreply.github.com>
Signed-off-by: Anuradha Karuppiah <26330987+AnuradhaKaruppiah@users.noreply.github.com>
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughEvaluator I/O moved from concrete Pydantic models to runtime-checkable Protocols; core and front-end type annotations were relaxed to protocol/BaseModel types. ATIF and evaluator import paths were updated across examples/tests/notebooks. Documentation now distinguishes base vs full Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Signed-off-by: Anuradha Karuppiah <26330987+AnuradhaKaruppiah@users.noreply.github.com>
Signed-off-by: Anuradha Karuppiah <26330987+AnuradhaKaruppiah@users.noreply.github.com>
Signed-off-by: Anuradha Karuppiah <26330987+AnuradhaKaruppiah@users.noreply.github.com>
Signed-off-by: Anuradha Karuppiah <26330987+AnuradhaKaruppiah@users.noreply.github.com>
637433d to
c8252c1
Compare
Signed-off-by: Anuradha Karuppiah <26330987+AnuradhaKaruppiah@users.noreply.github.com>
|
/ok to test 8a90e77 |
packages/nvidia_nat_eval/src/nat/plugins/eval/data_models/evaluator_io.py
Show resolved
Hide resolved
packages/nvidia_nat_eval/src/nat/plugins/eval/runtime/evaluate.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Anuradha Karuppiah <26330987+AnuradhaKaruppiah@users.noreply.github.com>
Signed-off-by: Anuradha Karuppiah <26330987+AnuradhaKaruppiah@users.noreply.github.com>
Signed-off-by: Anuradha Karuppiah <26330987+AnuradhaKaruppiah@users.noreply.github.com>
Signed-off-by: Anuradha Karuppiah <26330987+AnuradhaKaruppiah@users.noreply.github.com>
…export. Signed-off-by: Anuradha Karuppiah <26330987+AnuradhaKaruppiah@users.noreply.github.com>
There was a problem hiding this comment.
🧹 Nitpick comments (1)
docs/source/resources/migration-guide.md (1)
61-63: Clarify that these are alternative install options (choose one).These bullets read like cumulative steps; please label them as equivalent alternatives to avoid users installing all three paths.
As per coding guidelines, "Documentation must be clear and comprehensive."
Also applies to: 96-99
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@docs/source/resources/migration-guide.md` around lines 61 - 63, The three pip install bullets showing `pip install "nvidia-nat[eval]" nvidia-nat-langchain`, `pip install "nvidia-nat[eval-full]" nvidia-nat-langchain`, and `pip install "nvidia-nat-eval[full]" nvidia-nat-langchain` should be explicitly labeled as mutually exclusive alternatives; change the surrounding text to introduce them as "Choose one of the following install options:" (or prepend each bullet with "Option 1/2/3 — choose one:") so readers do not interpret them as cumulative steps, and apply the same clarification to the similar group at lines showing the other set (the bullets referenced in the comment at 96-99).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@docs/source/resources/migration-guide.md`:
- Around line 61-63: The three pip install bullets showing `pip install
"nvidia-nat[eval]" nvidia-nat-langchain`, `pip install "nvidia-nat[eval-full]"
nvidia-nat-langchain`, and `pip install "nvidia-nat-eval[full]"
nvidia-nat-langchain` should be explicitly labeled as mutually exclusive
alternatives; change the surrounding text to introduce them as "Choose one of
the following install options:" (or prepend each bullet with "Option 1/2/3 —
choose one:") so readers do not interpret them as cumulative steps, and apply
the same clarification to the similar group at lines showing the other set (the
bullets referenced in the comment at 96-99).
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 259445f5-9bf2-42f2-bd8a-37b3d845309d
📒 Files selected for processing (4)
docs/source/get-started/installation.mddocs/source/reference/cli.mddocs/source/resources/migration-guide.mdpyproject.toml
✅ Files skipped from review due to trivial changes (1)
- docs/source/get-started/installation.md
🚧 Files skipped from review as they are similar to previous changes (1)
- docs/source/reference/cli.md
2bf8b3e to
c55556b
Compare
Signed-off-by: Anuradha Karuppiah <26330987+AnuradhaKaruppiah@users.noreply.github.com>
c55556b to
38099ec
Compare
Signed-off-by: Anuradha Karuppiah <26330987+AnuradhaKaruppiah@users.noreply.github.com>
|
/ok to test 66e8b99 |
willkill07
left a comment
There was a problem hiding this comment.
Conditionally approving based on documentation update(s).
Co-authored-by: Will Killian <2007799+willkill07@users.noreply.github.com> Signed-off-by: Anuradha Karuppiah <26330987+AnuradhaKaruppiah@users.noreply.github.com>
Co-authored-by: Will Killian <2007799+willkill07@users.noreply.github.com> Signed-off-by: Anuradha Karuppiah <26330987+AnuradhaKaruppiah@users.noreply.github.com>
Signed-off-by: Anuradha Karuppiah <26330987+AnuradhaKaruppiah@users.noreply.github.com>
Signed-off-by: Anuradha Karuppiah <26330987+AnuradhaKaruppiah@users.noreply.github.com>
|
/ok to test 7fd7ade |
Signed-off-by: Anuradha Karuppiah <26330987+AnuradhaKaruppiah@users.noreply.github.com>
Signed-off-by: Anuradha Karuppiah <26330987+AnuradhaKaruppiah@users.noreply.github.com>
|
/ok to test b73421d |
…ith 429 Signed-off-by: Anuradha Karuppiah <26330987+AnuradhaKaruppiah@users.noreply.github.com>
|
/ok to test f3bdc49 |
…ilures with 429" This reverts commit f3bdc49. Signed-off-by: Anuradha Karuppiah <26330987+AnuradhaKaruppiah@users.noreply.github.com>
4bfa129 to
5589f7b
Compare
|
/ok to test 5589f7b |
Signed-off-by: Anuradha Karuppiah <26330987+AnuradhaKaruppiah@users.noreply.github.com>
|
/ok to test 703a6fd |
Signed-off-by: Anuradha Karuppiah <26330987+AnuradhaKaruppiah@users.noreply.github.com>
|
/ok to test f6905d3 |
|
/merge |
Description
Summary
Standalone ATIF custom evaluation should not require the full core runtime stack. This split preserves full config-driven nat eval behavior while enabling a lightweight dependency path for ATIF-native evaluation workflows.
Details
Notes
Complete Runtime Graph (rooted at nvidia-nat-eval)
By Submitting this PR I confirm:
Summary by CodeRabbit
Documentation
Refactor