fix(retriever): correctly cap PDF extract actors to avoid CPU oversubscription#1780
Closed
charlesbluca wants to merge 3 commits intoNVIDIA:mainfrom
Closed
fix(retriever): correctly cap PDF extract actors to avoid CPU oversubscription#1780charlesbluca wants to merge 3 commits intoNVIDIA:mainfrom
charlesbluca wants to merge 3 commits intoNVIDIA:mainfrom
Conversation
Collaborator
Author
|
Superseded by #1786 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a deadlock introduced when
GraphBatchIngestorreplacedBatchIngestoras the default batch runtime.Unlike the legacy path, the graph executor always passes operator classes (not instances) to
map_batches, which requiresActorPoolStrategyfor all nodes — includingPDFExtractionActor, which was previously usingTaskPoolStrategy.Persistent actors hold their CPU allocations continuously, so with the default 12 PDF extract actors × 2 CPUs each, plus ~9 CPUs from other actors in the pipeline (DocToPdf, PDFSplit, PageElements, OCR, UDF, Embed), a single-GPU/32-CPU machine requests 33 CPUs at startup and deadlocks —
ReadBinaryis immediately backpressured and no data ever flows.Checklist