Fix typo and improve test infrastructure robustness#1797
Fix typo and improve test infrastructure robustness#1797RobbiWillm wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
- Fix 'computaiton' typo in README.md - Add input validation to _wait_for_port in tests/integration/conftest.py to prevent invalid timeout/interval values This improves test reliability by catching configuration errors early. Signed-off-by: RobbiWillm <23glories.novas@icloud.com>
Greptile SummaryThis PR fixes a spelling error in Confidence Score: 5/5Safe to merge — both changes are minimal, correct, and non-breaking No P0 or P1 issues found; the typo fix is trivial and the input validation correctly uses <= 0 guards with clear error messages that do not affect any existing callers using default or valid positive values No files require special attention Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A["_wait_for_port(host, port, timeout, interval)"] --> B{timeout <= 0?}
B -- Yes --> C[raise ValueError]
B -- No --> D{interval <= 0?}
D -- Yes --> E[raise ValueError]
D -- No --> F[deadline = now + timeout]
F --> G{time.now < deadline?}
G -- Yes --> H[try socket.create_connection]
H -- success --> I[return]
H -- fail --> J[sleep interval]
J --> G
G -- No --> K[raise TimeoutError]
Reviews (1): Last reviewed commit: "docs: fix typo and improve test robustne..." | Re-trigger Greptile |
Summary
This PR makes two small improvements:
_wait_for_portfunction in integration test conftest.pyChanges
README.md
tests/integration/conftest.py
_wait_for_porthelperTesting
The conftest.py change improves test reliability by catching configuration errors early rather than hanging or producing confusing timeout errors.
Note: Changes to test infrastructure may benefit from running integration tests to verify no regressions.