Skip to content

Fix typo and improve test infrastructure robustness#1797

Open
RobbiWillm wants to merge 1 commit intoNVIDIA:mainfrom
RobbiWillm:docs/fix-readme-typo
Open

Fix typo and improve test infrastructure robustness#1797
RobbiWillm wants to merge 1 commit intoNVIDIA:mainfrom
RobbiWillm:docs/fix-readme-typo

Conversation

@RobbiWillm
Copy link
Copy Markdown

@RobbiWillm RobbiWillm commented Apr 5, 2026

Summary

This PR makes two small improvements:

  1. Documentation: Fixes in README.md ("computaiton" → "computation")
  2. Test Infrastructure: Adds input validation to _wait_for_port function in integration test conftest.py

Changes

README.md

  • Fixed spelling error on line 21

tests/integration/conftest.py

  • Added validation for negative timeout values in _wait_for_port helper
  • Added validation for negative interval values
  • This prevents silent failures from misconfigured test timeouts

Testing

The conftest.py change improves test reliability by catching configuration errors early rather than hanging or producing confusing timeout errors.


Note: Changes to test infrastructure may benefit from running integration tests to verify no regressions.

- Fix 'computaiton' typo in README.md

- Add input validation to _wait_for_port in tests/integration/conftest.py to prevent invalid timeout/interval values

This improves test reliability by catching configuration errors early.

Signed-off-by: RobbiWillm <23glories.novas@icloud.com>
@RobbiWillm RobbiWillm requested review from a team as code owners April 5, 2026 11:35
@RobbiWillm RobbiWillm requested a review from jperez999 April 5, 2026 11:35
@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot bot commented Apr 5, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@greptile-apps
Copy link
Copy Markdown

greptile-apps bot commented Apr 5, 2026

Greptile Summary

This PR fixes a spelling error in README.md (computaitoncomputation) and adds input validation to the _wait_for_port helper in the integration test conftest, raising ValueError for non-positive timeout or interval values. Both changes are minimal and correct — the guard conditions (<= 0) are appropriate, the error messages are clear, and the defaults (timeout=120.0, interval=0.5) are unaffected.

Confidence Score: 5/5

Safe to merge — both changes are minimal, correct, and non-breaking

No P0 or P1 issues found; the typo fix is trivial and the input validation correctly uses <= 0 guards with clear error messages that do not affect any existing callers using default or valid positive values

No files require special attention

Important Files Changed

Filename Overview
README.md Fixes typo 'computaiton' → 'computation'; no issues
tests/integration/conftest.py Adds positive-value guards for timeout and interval in _wait_for_port; logically sound and non-breaking

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A["_wait_for_port(host, port, timeout, interval)"] --> B{timeout <= 0?}
    B -- Yes --> C[raise ValueError]
    B -- No --> D{interval <= 0?}
    D -- Yes --> E[raise ValueError]
    D -- No --> F[deadline = now + timeout]
    F --> G{time.now < deadline?}
    G -- Yes --> H[try socket.create_connection]
    H -- success --> I[return]
    H -- fail --> J[sleep interval]
    J --> G
    G -- No --> K[raise TimeoutError]
Loading

Reviews (1): Last reviewed commit: "docs: fix typo and improve test robustne..." | Re-trigger Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant