Korean TN fixes: cardinal, decimal, fraction, date#374
Merged
tbartley94 merged 11 commits intoNVIDIA:ko_tn_staging_v1from Feb 20, 2026
Merged
Korean TN fixes: cardinal, decimal, fraction, date#374tbartley94 merged 11 commits intoNVIDIA:ko_tn_staging_v1from
tbartley94 merged 11 commits intoNVIDIA:ko_tn_staging_v1from
Conversation
Signed-off-by: Jinwoo Bae <34386414+bbae0312@users.noreply.github.com>
for more information, see https://pre-commit.ci
…zation Signed-off-by: Jinwoo Bae <34386414+bbae0312@users.noreply.github.com>
for more information, see https://pre-commit.ci
|
This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days. |
|
This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days. |
|
This PR was closed because it has been inactive for 7 days since being marked as stale. |
tbartley94
requested changes
Jan 27, 2026
nemo_text_processing/text_normalization/ko/taggers/electronic.py
Outdated
Show resolved
Hide resolved
nemo_text_processing/text_normalization/ko/taggers/telephone.py
Outdated
Show resolved
Hide resolved
nemo_text_processing/text_normalization/ko/taggers/telephone.py
Outdated
Show resolved
Hide resolved
nemo_text_processing/text_normalization/ko/taggers/tokenize_and_classify.py
Outdated
Show resolved
Hide resolved
Member
|
@bbae0312 Can you confirm tests passing (sparrowhawk and unit)? |
Signed-off-by: Jinwoo Bae <34386414+bbae0312@users.noreply.github.com>
for more information, see https://pre-commit.ci
|
This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days. |
Signed-off-by: Jinwoo Bae <34386414+bbae0312@users.noreply.github.com>
Author
|
Both unit tests and Sparrowhawk tests are passing locally. |
tbartley94
requested changes
Feb 18, 2026
Member
tbartley94
left a comment
tbartley94
left a comment
There was a problem hiding this comment.
naming and readability issues.
post processing.py is completely unnecessary
nemo_text_processing/text_normalization/ko/taggers/electronic.py
Outdated
Show resolved
Hide resolved
|
|
||
| cc16_grouped = four + sep_del + four + sep_del + four + sep_del + four | ||
| sep_to_space = pynutil.delete(sep_token) + insert_space | ||
| cc16_grouped = four + sep_to_space + four + sep_to_space + four + sep_to_space + four |
Author
There was a problem hiding this comment.
Got it, I’ll simplify with **3. Thanks!
nemo_text_processing/text_normalization/ko/taggers/tokenize_and_classify.py
Outdated
Show resolved
Hide resolved
nemo_text_processing/text_normalization/ko/verbalizers/post_processing.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Jinwoo Bae <34386414+bbae0312@users.noreply.github.com>
tbartley94
approved these changes
Feb 19, 2026
nemo_text_processing/text_normalization/ko/taggers/tokenize_and_classify.py
Outdated
Show resolved
Hide resolved
…ation Signed-off-by: Jinwoo Bae <34386414+bbae0312@users.noreply.github.com>
for more information, see https://pre-commit.ci
tbartley94
requested changes
Feb 19, 2026
nemo_text_processing/text_normalization/ko/verbalizers/post_processing.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Jinwoo Bae <34386414+bbae0312@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Add fixes and improvements for Korean TN: cardinal, decimal, ordinal, fraction, date, and post-processing.
Before your PR is "Ready for review"
Pre checks:
git commit -sto sign.pytestor (if your machine does not have GPU)pytest --cpufrom the root folder (given you marked your test cases accordingly@pytest.mark.run_only_on('CPU')).bash tools/text_processing_deployment/export_grammars.sh --MODE=test ...pytestand Sparrowhawk here.__init__.pyfor every folder and subfolder, includingdatafolder which has .TSV files?Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved.to all newly added Python files?Copyright 2015 and onwards Google, Inc.. See an example here.try import: ... except: ...) if not already done.PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.