Korean ITN staging v1 updates#387
Merged
tbartley94 merged 5 commits intoNVIDIA:ko_itn_staging_v1from Feb 20, 2026
Merged
Conversation
Signed-off-by: Jinwoo Bae <bbae7050@gmail.com>
for more information, see https://pre-commit.ci
tbartley94
requested changes
Feb 18, 2026
Member
tbartley94
left a comment
There was a problem hiding this comment.
unnecessary variables and code condensing
nemo_text_processing/inverse_text_normalization/ko/taggers/decimal.py
Outdated
Show resolved
Hide resolved
nemo_text_processing/inverse_text_normalization/ko/taggers/money.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Jinwoo Bae <bbae7050@gmail.com>
tbartley94
requested changes
Feb 19, 2026
Member
tbartley94
left a comment
There was a problem hiding this comment.
pending comments need follow up
nemo_text_processing/inverse_text_normalization/ko/taggers/money.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Jinwoo Bae <bbae7050@gmail.com>
Member
|
@bbae0312 lgtm. can you confirm tests are passing then i can merge? |
200199c to
45a54fa
Compare
for more information, see https://pre-commit.ci
Author
|
Passes both pytest and Sparrowhawk |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Follow-up updates to Korean ITN staging branch.
Includes:
Before your PR is "Ready for review"
Pre checks:
git commit -sto sign.pytestor (if your machine does not have GPU)pytest --cpufrom the root folder (given you marked your test cases accordingly@pytest.mark.run_only_on('CPU')).bash tools/text_processing_deployment/export_grammars.sh --MODE=test ...pytestand Sparrowhawk here.__init__.pyfor every folder and subfolder, includingdatafolder which has .TSV files?Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved.to all newly added Python files?Copyright 2015 and onwards Google, Inc.. See an example here.try import: ... except: ...) if not already done.PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.