Skip to content

Comments

Korean ITN staging v1 updates#387

Merged
tbartley94 merged 5 commits intoNVIDIA:ko_itn_staging_v1from
bbae0312:ko_itn_staging_v1
Feb 20, 2026
Merged

Korean ITN staging v1 updates#387
tbartley94 merged 5 commits intoNVIDIA:ko_itn_staging_v1from
bbae0312:ko_itn_staging_v1

Conversation

@bbae0312
Copy link

What does this PR do ?

Follow-up updates to Korean ITN staging branch.

Includes:

  • Time/date fixes
  • Ordinal and counter fixes
  • Whitelist additions
  • Updated test cases

Before your PR is "Ready for review"

Pre checks:

  • Have you signed your commits? Use git commit -s to sign.
  • Do all unittests finish successfully before sending PR?
    1. pytest or (if your machine does not have GPU) pytest --cpu from the root folder (given you marked your test cases accordingly @pytest.mark.run_only_on('CPU')).
    2. Sparrowhawk tests bash tools/text_processing_deployment/export_grammars.sh --MODE=test ...
  • If you are adding a new feature: Have you added test cases for both pytest and Sparrowhawk here.
  • Have you added __init__.py for every folder and subfolder, including data folder which has .TSV files?
  • Have you followed codeQL results and removed unused variables and imports (report is at the bottom of the PR in github review box) ?
  • Have you added the correct license header Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved. to all newly added Python files?
  • If you copied nemo_text_processing/text_normalization/en/graph_utils.py your header's second line should be Copyright 2015 and onwards Google, Inc.. See an example here.
  • Remove import guards (try import: ... except: ...) if not already done.
  • If you added a new language or a new feature please update the NeMo documentation (lives in different repo).
  • Have you added your language support to tools/text_processing_deployment/pynini_export.py.

PR Type:

  • New Feature
  • Bugfix
  • Documentation
  • Test

If you haven't finished some of the above items you can still open "Draft" PR.

bbae0312 and others added 2 commits February 17, 2026 15:20
Signed-off-by: Jinwoo Bae <bbae7050@gmail.com>
Copy link
Member

@tbartley94 tbartley94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unnecessary variables and code condensing

Signed-off-by: Jinwoo Bae <bbae7050@gmail.com>
Copy link
Member

@tbartley94 tbartley94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pending comments need follow up

Signed-off-by: Jinwoo Bae <bbae7050@gmail.com>
@tbartley94
Copy link
Member

@bbae0312 lgtm. can you confirm tests are passing then i can merge?

@bbae0312
Copy link
Author

Passes both pytest and Sparrowhawk

@tbartley94 tbartley94 merged commit aaeab10 into NVIDIA:ko_itn_staging_v1 Feb 20, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants