Skip to content

Remove dataset UI surfaces#1093

Open
ethany-nv wants to merge 1 commit into
mainfrom
ethany/dataset_frontend_removal
Open

Remove dataset UI surfaces#1093
ethany-nv wants to merge 1 commit into
mainfrom
ethany/dataset_frontend_removal

Conversation

@ethany-nv

@ethany-nv ethany-nv commented Jun 11, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Collaborator

Issue #911

Summary:

  • Remove the /datasets route tree, dataset feature modules, adapters, server helpers, proxy route, mocks, and dataset-specific E2E coverage.
  • Remove the Datasets sidebar item and route warmup.
  • Remove the submit-workflow dataset.localpath warning/detection path while preserving files[].localpath blocking.

Validation:

  • pnpm type-check
  • pnpm lint
  • pnpm format:check
  • pnpm test -- src/components/submit-workflow/detect-localpath.test.ts src/lib/navigation/config.test.ts
  • pnpm test:e2e -- e2e/journeys/navigation.spec.ts e2e/journeys/empty-states.spec.ts e2e/journeys/submit-workflow-form.spec.ts

Checklist:

  • Existing tests pass
  • Added/updated tests
  • Manual validation not needed

Summary by CodeRabbit

  • Removals

    • Removed the Datasets feature and all associated pages, UI components, and navigation entries from the application.

  • Bug Fixes

    • Simplified workflow submission validation to only block on file-level localpath issues, no longer blocking on dataset-level localpath configuration.

  • Tests

    • Removed all dataset-related end-to-end test coverage and mock fixtures.

@ethany-nv ethany-nv requested a review from a team as a code owner June 11, 2026 20:35
@coderabbitai

coderabbitai Bot commented Jun 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

This PR removes the entire datasets feature from the OSMO UI codebase, including all route handlers, page components, UI components for list and detail views, API adapters and hooks, mock data infrastructure, and E2E tests. Dataset-level localpath warnings are removed from workflow submission while retaining file-level checks. Navigation is updated to remove datasets references.

Changes

Datasets Feature Removal

Layer / File(s) Summary
Dataset routes and page components
src/ui/src/app/(dashboard)/datasets/, src/ui/src/lib/api/server/dataset-actions.production.ts		 All dataset route handlers removed: /datasets page, /datasets/[bucket] redirect, and /datasets/[bucket]/[name] detail pages with error boundaries. Production manifest fetching server action deleted.
Datasets list UI and stores
src/ui/src/features/datasets/list/, src/ui/src/mocks/factories.ts		 Remove datasets-page-content, datasets-page-skeleton, datasets-with-data components; delete DatasetsDataTable and DatasetsToolbar; remove all column definitions, stores, search fields, and filter utilities. Delete dataset factory exports from mock factories.
Datasets detail and file browser components
src/ui/src/features/datasets/detail/, src/ui/src/features/datasets/layout/		 Remove dataset-detail-content, dataset-detail-skeleton, dataset-detail-with-data; delete file-browser-table, file-browser-breadcrumb, file-browser-control-strip components; remove version-picker and file-preview-panel; delete file browser state hook and all layout context/store/components.
Datasets API adapter and data fetching
src/ui/src/lib/api/adapter/datasets*.ts, src/ui/src/lib/api/server/datasets.ts		 Remove datasets.ts adapter (all types, transformers, fetch functions, query builders); delete datasets-hooks.ts React Query hooks; remove dataset-search.ts manifest search API; delete server-side prefetch utilities.
Datasets mock infrastructure and E2E setup
src/ui/e2e/, src/ui/src/mocks/, src/ui/src/lib/e2e/		 Remove dataset-generator.ts; delete dataset-manifest-fixtures.ts; update e2e/global-setup.ts to drop /datasets from warmup routes; update e2e/mock-api-backend.mjs to remove manifest endpoint; remove setupDatasets from mock-setup.ts; delete all dataset-related MSW handlers and update mock configuration to remove dataset volume tracking.
Workflow form and navigation updates
src/ui/src/components/submit-workflow/, src/ui/src/lib/navigation/, src/ui/e2e/journeys/*.spec.ts, docs/		 Remove dataset-localpath field from LocalpathWarnings interface and detection logic; delete dataset-localpath warning UI from submit panel; update gating to only check hasFileLocalpath; remove Datasets entry from sidebar navigation; update navigation tests; remove dataset-related E2E journey tests and examples; update documentation to reflect removed dataset endpoints and TODOs.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

Suggested reviewers

  • RyaliNvidia
  • fernandol-nvidia

🐰 A rabbit once hopped through these halls,
Finding datasets in every folder and call,
But now they're all gone with a sweep and a bound,
The codebase is lighter—no datasets around! ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 66.67% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Remove dataset UI surfaces' directly and clearly describes the primary change: removing the dataset-related frontend features. It is concise, specific, and captures the main intent.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ethany/dataset_frontend_removal

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov

codecov Bot commented Jun 11, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 53.04%. Comparing base (221c012) to head (7c21a1c).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1093      +/-   ##
==========================================
- Coverage   53.15%   53.04%   -0.12%     
==========================================
  Files         220      214       -6     
  Lines       28691    28363     -328     
  Branches     4296     4199      -97     
==========================================
- Hits        15252    15045     -207     
+ Misses      12738    12634     -104     
+ Partials      701      684      -17
Flag Coverage Δ
backend 54.51% <ø> (-0.32%) ⬇️
ui 35.00% <ø> (+0.27%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/ui/src/lib/api/adapter/types.ts 100.00% <ø> (ø)
src/ui/src/lib/date-range-utils.ts 97.72% <ø> (ø)
src/ui/src/lib/navigation/config.ts 100.00% <ø> (ø)

... and 6 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

coderabbitai[bot]
coderabbitai Bot reviewed Jun 11, 2026
View reviewed changes

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/ui/e2e/journeys/navigation.spec.ts`:
- Around line 29-30: Update AGENTS.md’s "Codebase Structure" -> "Key routes"
section to remove or modify the entry that lists "/datasets" so it no longer
references the removed UI surface; search for the "Codebase Structure" heading
and the "Key routes" subsection in AGENTS.md, remove the "/datasets" bullet (or
replace it with the correct current route) and ensure the list and any
explanatory text reflect the current routes such as "/resources" and
"/occupancy".
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: a2a220b9-dcd7-4b1c-a03f-bb5f9f108cb8

📥 Commits

Reviewing files that changed from the base of the PR and between d5f5214 and 7c21a1c.

📒 Files selected for processing (78)
  • src/ui/e2e/global-setup.ts
  • src/ui/e2e/journeys/dataset-detail.spec.ts
  • src/ui/e2e/journeys/dataset-file-browser.spec.ts
  • src/ui/e2e/journeys/dataset-filters.spec.ts
  • src/ui/e2e/journeys/dataset-panel.spec.ts
  • src/ui/e2e/journeys/dataset-version-picker.spec.ts
  • src/ui/e2e/journeys/datasets.spec.ts
  • src/ui/e2e/journeys/empty-states.spec.ts
  • src/ui/e2e/journeys/navigation.spec.ts
  • src/ui/e2e/journeys/submit-workflow-form.spec.ts
  • src/ui/e2e/mock-api-backend.mjs
  • src/ui/e2e/utils/mock-setup.ts
  • src/ui/next.config.ts
  • src/ui/playwright.config.ts
  • src/ui/src/app/(dashboard)/datasets/[bucket]/[name]/error.tsx
  • src/ui/src/app/(dashboard)/datasets/[bucket]/[name]/page.tsx
  • src/ui/src/app/(dashboard)/datasets/[bucket]/page.tsx
  • src/ui/src/app/(dashboard)/datasets/error.tsx
  • src/ui/src/app/(dashboard)/datasets/layout.tsx
  • src/ui/src/app/(dashboard)/datasets/page.tsx
  • src/ui/src/app/api/e2e/dataset-manifest/route.ts
  • src/ui/src/app/proxy/dataset/file/route.impl.production.ts
  • src/ui/src/app/proxy/dataset/file/route.impl.ts
  • src/ui/src/app/proxy/dataset/file/route.ts
  • src/ui/src/components/copyable-value.tsx
  • src/ui/src/components/submit-workflow/detect-localpath.test.ts
  • src/ui/src/components/submit-workflow/detect-localpath.ts
  • src/ui/src/components/submit-workflow/submit-workflow-config-panel.tsx
  • src/ui/src/components/submit-workflow/use-submit-workflow-form.ts
  • src/ui/src/features/datasets/detail/components/dataset-detail-content.tsx
  • src/ui/src/features/datasets/detail/components/dataset-detail-skeleton.tsx
  • src/ui/src/features/datasets/detail/components/dataset-detail-with-data.tsx
  • src/ui/src/features/datasets/detail/components/file-browser-breadcrumb.tsx
  • src/ui/src/features/datasets/detail/components/file-browser-control-strip.tsx
  • src/ui/src/features/datasets/detail/components/file-browser-table.tsx
  • src/ui/src/features/datasets/detail/components/file-preview-panel.tsx
  • src/ui/src/features/datasets/detail/components/version-picker.tsx
  • src/ui/src/features/datasets/detail/hooks/use-file-browser-state.ts
  • src/ui/src/features/datasets/layout/datasets-panel-context.tsx
  • src/ui/src/features/datasets/layout/datasets-panel-layout.tsx
  • src/ui/src/features/datasets/layout/datasets-panel-store.ts
  • src/ui/src/features/datasets/list/components/datasets-page-content.tsx
  • src/ui/src/features/datasets/list/components/datasets-page-skeleton.tsx
  • src/ui/src/features/datasets/list/components/datasets-with-data.tsx
  • src/ui/src/features/datasets/list/components/panel/collection-panel-members.tsx
  • src/ui/src/features/datasets/list/components/panel/dataset-panel-details.tsx
  • src/ui/src/features/datasets/list/components/panel/dataset-panel-versions.tsx
  • src/ui/src/features/datasets/list/components/panel/dataset-panel.tsx
  • src/ui/src/features/datasets/list/components/table/dataset-column-defs.tsx
  • src/ui/src/features/datasets/list/components/table/datasets-data-table.tsx
  • src/ui/src/features/datasets/list/components/toolbar/datasets-toolbar.tsx
  • src/ui/src/features/datasets/list/hooks/use-datasets-async-fields.ts
  • src/ui/src/features/datasets/list/hooks/use-datasets-data.ts
  • src/ui/src/features/datasets/list/lib/dataset-columns.ts
  • src/ui/src/features/datasets/list/lib/dataset-search-fields.ts
  • src/ui/src/features/datasets/list/lib/date-filter-utils.ts
  • src/ui/src/features/datasets/list/stores/datasets-table-store.ts
  • src/ui/src/features/pools/hooks/use-pools-data.ts
  • src/ui/src/lib/api/adapter/BACKEND_TODOS.md
  • src/ui/src/lib/api/adapter/dataset-search.test.ts
  • src/ui/src/lib/api/adapter/dataset-search.ts
  • src/ui/src/lib/api/adapter/datasets-hooks.ts
  • src/ui/src/lib/api/adapter/datasets-shim.ts
  • src/ui/src/lib/api/adapter/datasets.test.ts
  • src/ui/src/lib/api/adapter/datasets.ts
  • src/ui/src/lib/api/adapter/types.ts
  • src/ui/src/lib/api/server/dataset-actions.production.ts
  • src/ui/src/lib/api/server/datasets.ts
  • src/ui/src/lib/date-range-utils.ts
  • src/ui/src/lib/e2e/dataset-manifest-fixtures.ts
  • src/ui/src/lib/navigation/config.test.ts
  • src/ui/src/lib/navigation/config.ts
  • src/ui/src/mocks/README.md
  • src/ui/src/mocks/factories.ts
  • src/ui/src/mocks/generators/dataset-generator.ts
  • src/ui/src/mocks/global-config.ts
  • src/ui/src/mocks/handlers.ts
  • src/ui/src/mocks/mock-provider.tsx
💤 Files with no reviewable changes (60)
  • src/ui/src/features/datasets/layout/datasets-panel-store.ts
  • src/ui/src/app/(dashboard)/datasets/[bucket]/[name]/page.tsx
  • src/ui/src/features/datasets/detail/components/file-preview-panel.tsx
  • src/ui/src/features/datasets/list/components/datasets-page-skeleton.tsx
  • src/ui/src/lib/api/server/datasets.ts
  • src/ui/src/app/(dashboard)/datasets/[bucket]/page.tsx
  • src/ui/src/app/(dashboard)/datasets/layout.tsx
  • src/ui/src/features/datasets/detail/components/dataset-detail-content.tsx
  • src/ui/e2e/journeys/dataset-filters.spec.ts
  • src/ui/src/features/datasets/list/components/panel/collection-panel-members.tsx
  • src/ui/src/app/(dashboard)/datasets/error.tsx
  • src/ui/src/app/api/e2e/dataset-manifest/route.ts
  • src/ui/src/features/datasets/list/stores/datasets-table-store.ts
  • src/ui/src/features/datasets/detail/components/dataset-detail-skeleton.tsx
  • src/ui/src/app/proxy/dataset/file/route.impl.ts
  • src/ui/src/features/datasets/list/hooks/use-datasets-data.ts
  • src/ui/src/features/datasets/list/components/table/dataset-column-defs.tsx
  • src/ui/src/features/datasets/list/components/datasets-page-content.tsx
  • src/ui/src/features/datasets/detail/components/dataset-detail-with-data.tsx
  • src/ui/e2e/journeys/dataset-panel.spec.ts
  • src/ui/e2e/journeys/dataset-version-picker.spec.ts
  • src/ui/e2e/journeys/dataset-file-browser.spec.ts
  • src/ui/src/lib/api/server/dataset-actions.production.ts
  • src/ui/src/features/datasets/layout/datasets-panel-layout.tsx
  • src/ui/src/features/datasets/detail/components/file-browser-breadcrumb.tsx
  • src/ui/src/features/datasets/layout/datasets-panel-context.tsx
  • src/ui/src/app/proxy/dataset/file/route.ts
  • src/ui/src/features/datasets/list/lib/date-filter-utils.ts
  • src/ui/src/features/datasets/detail/hooks/use-file-browser-state.ts
  • src/ui/src/features/datasets/list/components/datasets-with-data.tsx
  • src/ui/e2e/journeys/dataset-detail.spec.ts
  • src/ui/src/features/datasets/list/components/table/datasets-data-table.tsx
  • src/ui/src/features/datasets/list/components/panel/dataset-panel-details.tsx
  • src/ui/src/features/datasets/list/lib/dataset-search-fields.ts
  • src/ui/src/features/datasets/list/components/toolbar/datasets-toolbar.tsx
  • src/ui/src/features/datasets/list/components/panel/dataset-panel-versions.tsx
  • src/ui/src/app/proxy/dataset/file/route.impl.production.ts
  • src/ui/src/app/(dashboard)/datasets/[bucket]/[name]/error.tsx
  • src/ui/src/lib/api/adapter/dataset-search.ts
  • src/ui/src/lib/e2e/dataset-manifest-fixtures.ts
  • src/ui/e2e/journeys/datasets.spec.ts
  • src/ui/src/lib/api/adapter/datasets.test.ts
  • src/ui/src/mocks/global-config.ts
  • src/ui/src/features/datasets/list/lib/dataset-columns.ts
  • src/ui/src/app/(dashboard)/datasets/page.tsx
  • src/ui/src/features/datasets/list/components/panel/dataset-panel.tsx
  • src/ui/src/mocks/generators/dataset-generator.ts
  • src/ui/src/features/datasets/detail/components/file-browser-table.tsx
  • src/ui/src/features/datasets/detail/components/file-browser-control-strip.tsx
  • src/ui/src/lib/api/adapter/datasets-shim.ts
  • src/ui/src/features/datasets/list/hooks/use-datasets-async-fields.ts
  • src/ui/src/mocks/mock-provider.tsx
  • src/ui/src/lib/api/adapter/datasets-hooks.ts
  • src/ui/src/features/datasets/detail/components/version-picker.tsx
  • src/ui/src/lib/api/adapter/dataset-search.test.ts
  • src/ui/src/mocks/README.md
  • src/ui/src/lib/api/adapter/datasets.ts
  • src/ui/next.config.ts
  • src/ui/e2e/journeys/empty-states.spec.ts
  • src/ui/src/lib/api/adapter/BACKEND_TODOS.md

Comment thread src/ui/e2e/journeys/navigation.spec.ts
Comment on lines +29 to 30
* Resources /resources · Occupancy /occupancy
*

@coderabbitai coderabbitai Bot Jun 11, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Verify AGENTS.md changed in this branch and check dataset references in codebase-structure docs.
BASE="$(git merge-base HEAD origin/main 2>/dev/null || true)"
if [ -n "$BASE" ]; then
  git diff --name-only "$BASE"..HEAD | rg -n '^AGENTS\.md$'
else
  git show --name-only --pretty='' HEAD | rg -n '^AGENTS\.md$'
fi

rg -n 'Codebase Structure|dataset|datasets' AGENTS.md

Repository: NVIDIA/OSMO

Length of output: 1209

Update AGENTS.md “Codebase Structure” to reflect /datasets removal.
AGENTS.md still lists “datasets” under the “Key routes” in the “Codebase Structure” section, so the /datasets UI surface removal isn’t reflected in the same change.

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/ui/e2e/journeys/navigation.spec.ts` around lines 29 - 30, Update
AGENTS.md’s "Codebase Structure" -> "Key routes" section to remove or modify the
entry that lists "/datasets" so it no longer references the removed UI surface;
search for the "Codebase Structure" heading and the "Key routes" subsection in
AGENTS.md, remove the "/datasets" bullet (or replace it with the correct current
route) and ensure the list and any explanatory text reflect the current routes
such as "/resources" and "/occupancy".

Source: Coding guidelines

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@fernandol-nvidia fernandol-nvidia fernandol-nvidia approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ethany-nv @fernandol-nvidia