scheduler: add 'none' scheduler_type to skip PodGroup creation#976
Draft
jiaenren wants to merge 1 commit into
Draft
scheduler: add 'none' scheduler_type to skip PodGroup creation#976jiaenren wants to merge 1 commit into
jiaenren wants to merge 1 commit into
Conversation
Adds `BackendSchedulerType.NONE` so workflows can run on the K8s default scheduler without a kai-scheduler dependency. With `scheduler_type='none'`, the base K8sObjectFactory writes `scheduler_name` to `pod.spec.schedulerName` and skips PodGroup CR creation, scheduler resource CRDs (queues, topologies), and priority/topology features — exactly Option C from #936. Mirrors the new enum value into the generated UI types. Resolves #936. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #976 +/- ##
==========================================
- Coverage 44.53% 44.53% -0.01%
==========================================
Files 218 218
Lines 28537 28540 +3
Branches 4260 4261 +1
==========================================
+ Hits 12708 12709 +1
- Misses 15208 15210 +2
Partials 621 621
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements Option C from #936: a new
BackendSchedulerType.NONEthat skips PodGroup CR creation and runs pods on the K8s default scheduler — removing the kai-scheduler hard dependency for workflows that don't need gang scheduling.BackendSchedulerTypeaccepts'none'in addition to'kai'.get_k8s_object_factory()returns the baseK8sObjectFactory(scheduler_name)forNONE. The base class already does what 'none' needs:scheduler_namewritten topod.spec.schedulerNamepriority_supported/topology_supportedreturnFalseopenapi.json+ UI generated types mirror the new enum value.15 lines of code change across 5 files. The default behavior (
scheduler_type='kai') is unchanged.Test plan
OETF scenario test (in the internal harness, not part of this PR) exercises the path end-to-end on KIND:
/api/configs/backend/defaultwithscheduler_type='none',scheduler_name='default-scheduler'.validation/workflow/serial_workflow.yaml.COMPLETED.addCleanuprestores the original backend config.TDD verification on
oetf:deploy --env kind --build-local:422 Input should be 'kai'(the exact symptom from #936)🤖 Generated with Claude Code
Summary by CodeRabbit