Skip to content

feat: support quick-start object storage secret refs #982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yoosful wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: support quick-start object storage secret refs #982

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions deployments/charts/quick-start/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,9 @@ This chart installs and configures:
| `global.objectStorage.overrideUrl` | Object storage override URL (changed for localstack-s3) | `"http://localstack-s3.osmo:4566"` |
| `global.objectStorage.accessKeyId` | Object storage access key ID for authentication | `"test"` |
| `global.objectStorage.accessKey` | Object storage access key for authentication | `"test"` |
| `global.objectStorage.existingSecret.name` | Existing Secret containing object storage credentials | `""` |
| `global.objectStorage.existingSecret.accessKeyIdKey` | Secret key for the object storage access key ID | `"access_key_id"` |
| `global.objectStorage.existingSecret.accessKeyKey` | Secret key for the object storage access key | `"access_key"` |
| `global.objectStorage.region` | Object storage region where the bucket is located | `"us-east-1"` |

### Gateway Configuration
Expand Down
13 changes: 13 additions & 0 deletions deployments/charts/quick-start/templates/config-setup.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,10 +256,23 @@ spec:
value: {{ .Values.global.objectStorage.endpoint | quote }}
- name: OBJECT_STORAGE_OVERRIDE_URL
value: {{ .Values.global.objectStorage.overrideUrl | quote }}
{{- if .Values.global.objectStorage.existingSecret.name }}
- name: OBJECT_STORAGE_ACCESS_KEY_ID
valueFrom:
secretKeyRef:
name: {{ .Values.global.objectStorage.existingSecret.name | quote }}
key: {{ .Values.global.objectStorage.existingSecret.accessKeyIdKey | quote }}
- name: OBJECT_STORAGE_ACCESS_KEY
valueFrom:
secretKeyRef:
name: {{ .Values.global.objectStorage.existingSecret.name | quote }}
key: {{ .Values.global.objectStorage.existingSecret.accessKeyKey | quote }}
{{- else }}
- name: OBJECT_STORAGE_ACCESS_KEY_ID
value: {{ .Values.global.objectStorage.accessKeyId | quote }}
- name: OBJECT_STORAGE_ACCESS_KEY
value: {{ .Values.global.objectStorage.accessKey | quote }}
{{- end }}
- name: OBJECT_STORAGE_REGION
value: {{ .Values.global.objectStorage.region | quote }}
- name: CONTAINER_REGISTRY
Expand Down
8 changes: 8 additions & 0 deletions deployments/charts/quick-start/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,14 @@ global:
## Object storage access key for authentication
##
accessKey: "test"
## Existing Kubernetes Secret for object storage credentials.
## When name is set, config-setup reads accessKeyId/accessKey from this Secret
## instead of rendering the plain values above into the Job manifest.
##
existingSecret:
name: ""
accessKeyIdKey: "access_key_id"
accessKeyKey: "access_key"
## Object storage region where the bucket is located
##
region: "us-east-1"
Expand Down