fix(sandbox): disable child core dumps#821
Merged
johntmyers merged 1 commit intomainfrom Apr 15, 2026
Merged
Conversation
|
🌿 Preview your docs: https://nvidia-preview-pr-821.docs.buildwithfern.com/openshell |
Signed-off-by: John Myers <9696606+johntmyers@users.noreply.github.com>
c758d83 to
7df53c4
Compare
drew
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Disable core dumps for sandbox child processes in both process spawn and SSH exec flows, and document and test the new hardening.
Related Issue
Linear: OS-75
Changes
RLIMIT_CORE=0on Unix andPR_SET_DUMPABLE=0on LinuxProcessHandle::spawn_impl()paths and the SSHenter_netns_and_sandbox()path before Landlock/seccomp enforcementulimit -cis0inside the sandboxTesting
mise run pre-commitpassesLocal verification:
cargo fmt --allcargo test -p openshell-sandbox harden_child_process_disables_core_dumps --libmise run python:protomise run pre-commiton this host (z3.hmissing forz3-sys)mise run teston this host (z3.hmissing forz3-sys)mise run e2elocally (stopped; planning to rely on GitHub CI)Checklist