fix(build): match only semver tags in git_version()#835
Closed
Ai-chan-0411 wants to merge 1 commit intoNVIDIA:mainfrom
Closed
fix(build): match only semver tags in git_version()#835Ai-chan-0411 wants to merge 1 commit intoNVIDIA:mainfrom
Ai-chan-0411 wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
Change --match pattern from "v*" to "v[0-9]*" so that git describe only considers semantic version tags (e.g. v0.0.28) and skips non-version tags like vm-dev. Closes NVIDIA#832
|
Thank you for your interest in contributing to OpenShell, @Ai-chan-0411. This project uses a vouch system for first-time contributors. Before submitting a pull request, you need to be vouched by a maintainer. To get vouched:
See CONTRIBUTING.md for details. |
|
Thank you for your submission! We ask that you sign our Developer Certificate of Origin before we can accept your contribution. You can sign the DCO by adding a comment below using this text: I have read the DCO document and I hereby sign the DCO. You can retrigger this bot by commenting recheck in this Pull Request. Posted by the DCO Assistant Lite bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
git_version()inbuild.rsto use--match "v[0-9]*"instead of--match "v*"so that non-version tags likevm-devare excluded fromgit describeoutputCloses #832
Root cause
git describe --tags --long --match "v*"matches bothv0.0.28andvm-devsince both start withv. Whenvm-devis on a more recent commit, git picks it, resulting in the version stringm-devafter thevprefix is stripped.Fix
Change the glob pattern from
v*tov[0-9]*so only tags that start withvfollowed by a digit (i.e. semantic version tags likev0.0.28) are matched.Test plan
git describe --tags --long --match "v[0-9]*"skipsvm-devand returns the correct semver tagopenshell --versionshows the expected version