Skip to content

Conversation

@mdboom
Copy link
Contributor

@mdboom mdboom commented Jan 9, 2026

Prerequsite: #1446

Description

  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@copy-pr-bot
Copy link
Contributor

copy-pr-bot bot commented Jan 9, 2026

Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request adds event-related APIs to the cuda.core.system module, enabling applications to register and wait for hardware events from CUDA devices. The implementation provides a high-level Python interface over NVML's event system.

Key changes include:

  • Addition of EventType, EventData, and DeviceEvents classes for event handling
  • New Device.register_events() and Device.get_supported_event_types() methods
  • Refactored system event handling in NVML bindings with proper versioned API usage
  • Array size fixes in NumPy dtype definitions for proper struct array handling

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 10 comments.

Show a summary per file
File Description
cuda_core/tests/system/test_system_device.py Adds test coverage for event registration and timeout behavior
cuda_core/docs/source/api.rst Documents new public API classes: DeviceEvents, EventData, EventType
cuda_core/cuda/core/system/_device_utils.pxi Removes unused import and cleans up internal documentation
cuda_core/cuda/core/system/_device.pyx Implements EventType, EventData, and DeviceEvents classes with device event APIs
cuda_bindings/cuda/bindings/_nvml.pyx Refactors system event functions to use versioned structs and fixes array dtype definitions
cuda_bindings/cuda/bindings/_nvml.pxd Removes old system event declarations and typedef

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mdboom mdboom added the cuda.core Everything related to the cuda.core module label Jan 9, 2026
@mdboom mdboom self-assigned this Jan 9, 2026
@mdboom mdboom marked this pull request as draft January 9, 2026 15:02
@copy-pr-bot
Copy link
Contributor

copy-pr-bot bot commented Jan 9, 2026

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@mdboom mdboom force-pushed the cuda.core.system-events branch from 05cca22 to fe4aae4 Compare January 9, 2026 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cuda.core Everything related to the cuda.core module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant