[cudf] Require explicit stream and MR for test make_null_mask - #23639
Draft
nirandaperera wants to merge 1 commit into
Draft
[cudf] Require explicit stream and MR for test make_null_mask#23639nirandaperera wants to merge 1 commit into
make_null_mask#23639nirandaperera wants to merge 1 commit into
Conversation
Signed-off-by: niranda perera <niranda.perera@gmail.com>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a low-priority change, and would likely be automatically addressed when #20780 completes.
Depends on #23581
A part of #20780.
cudf::test::detail::make_null_maskstill defaulted to the test stream and current device resource, which hid unintentional resource use. This removes those defaults and updates callers to pass stream and memory resources explicitly.stream/mrparameters fromdetail::make_null_maskstream/mrat direct test call sites, including nested lambdas that now capture themcudf::get_default_stream()/cudf::get_current_device_resource_ref()inside the helpers until those modules are migratedNOTE:
In many instances, the default stream and current MR are now defined in test fixture scopes. Ideally when each module is ported to
memory_resources, corresponding test cases and utils should follow suite.Checklist