Skip to content

Disable cuml-compat-tests for cpp-only PR changes - #23644

Open
davidwendt wants to merge 1 commit into
NVIDIA:mainfrom
davidwendt:cuml-disable-cpp-only
Open

Disable cuml-compat-tests for cpp-only PR changes#23644
davidwendt wants to merge 1 commit into
NVIDIA:mainfrom
davidwendt:cuml-disable-cpp-only

Conversation

@davidwendt

Copy link
Copy Markdown
Contributor

Description

Disable cuml tests when C++ only changes appear in a PR.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt self-assigned this Aug 13, 2026
@davidwendt
davidwendt requested a review from a team as a code owner August 13, 2026 02:02
@davidwendt
davidwendt requested a review from jameslamb August 13, 2026 02:02
@davidwendt davidwendt added 3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Aug 13, 2026
@coderabbitai

coderabbitai Bot commented Aug 13, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: dadf8da0-b2ad-44be-871a-735a7535616f

📥 Commits

Reviewing files that changed from the base of the PR and between 9ed1bdc and 92cb053.

📒 Files selected for processing (1)
  • .github/workflows/pr.yaml

📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Updated compatibility test workflow conditions to run only for relevant Python and Conda changes.
    • Excluded C++ changes and selected components from triggering the compatibility test job.

Walkthrough

The pull request updates the cuml-compat-tests workflow condition. The job now skips changes that include C++ files, in addition to existing exclusions for cudf_polars and dask_cudf.

Changes

cuml compatibility test gating

Layer / File(s) Summary
Workflow condition update
.github/workflows/pr.yaml
The cuml-compat-tests job now requires neither_cpp_nor_cudf_polars_nor_dask_cudf for execution.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Mergeability Score: ⚪ Minimal · up to 92cb0

This localized workflow change skips compatibility tests only for C++-only pull requests while retaining them for mixed changes; no actionable merge-blocking risk remains beyond normal review.

Suggested reviewers: jameslamb, mroeschke

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the change to disable cuml-compat-tests for C++-only pull requests.
Description check ✅ Passed The description directly explains that cuml tests are disabled when a pull request contains only C++ changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants