Use a proper libcuvs library when RAPIDS_VERSION points to a PR branch#181
Open
imotov wants to merge 8 commits into
Open
Use a proper libcuvs library when RAPIDS_VERSION points to a PR branch#181imotov wants to merge 8 commits into
imotov wants to merge 8 commits into
Conversation
Ensures that if RAPIDS_VERSION is pointing to a pull request and had any C changes, CI build libcuvs together with cuvs-java.
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Contributor
Author
|
/ok to test 0f99843 |
Contributor
Author
|
/ok to test c747438 |
Contributor
Author
|
/ok to test 765287e |
imotov
added
improvement
imotov
marked this pull request as ready for review
July 24, 2026 22:53
imotov
marked this pull request as draft
July 25, 2026 00:33
Contributor
Author
|
/ok to test 4390739 |
Contributor
Author
|
/ok to test a70ec95 |
Contributor
Author
|
/ok to test 3ef6ebf |
Contributor
Author
|
/ok to test ee601b3 |
imotov
changed the title
imotov
changed the title
Contributor
Author
|
/ok to test 5ed991c |
imotov
marked this pull request as ready for review
July 25, 2026 01:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Many
cuvs-lucenePRs depend oncuvsPRs that have not yet been merged. There is a way to test suchcuvs-lucenePRs in CI by temporary pointingRAPIDS_VERSIONto thecuvsPR branch. Unfortunately, this approach only works when the C portion ofcuvshas not changed, because it relies on a conda'slibcuvsrather than building it from source.This PR works around this by downloading the pre-built libcuvs conda artifact from the cuVS PR's own CI run via gh run download. The artifact is extracted with rapids-extract-conda-files and prepended to LD_LIBRARY_PATH, so the Java bindings are built and tested against the correct library.