Skip to content

cuvs: add package version retrieval function #2337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
QuerthDP wants to merge 1 commit into
base: main
Choose a base branch
from
+15 −0
Open

cuvs: add package version retrieval function #2337

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions rust/cuvs/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,3 +26,18 @@ pub mod vamana;
pub use dlpack::{AsDlTensor, AsDlTensorMut, DLPackError, DLTensorView, DLTensorViewMut, DType};
pub use error::{Error, Result};
pub use resources::Resources;

/// Returns the version of this `cuvs` crate.
pub fn version() -> &'static str {
env!("CARGO_PKG_VERSION")
}
Comment on lines +31 to +33

@yan-zaretskiy yan-zaretskiy Jul 22, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest instead to wrap the underlying FFI function like so.

/// Returns the cuVS library version as `(major, minor, patch)`.
pub fn version() -> Result<(u16, u16, u16), LibraryError> {
    let mut major: u16 = 0;
    let mut minor: u16 = 0;
    let mut patch: u16 = 0;

    // SAFETY:
    // - All three pointers are valid, aligned `u16` locals.
    let status = unsafe { ffi::cuvsVersionGet(&mut major, &mut minor, &mut patch) };
    check_cuvs(status)?;
    Ok((major, minor, patch))
}


#[cfg(test)]
mod tests {
use super::*;

#[test]
fn test_version() {
assert_eq!(version(), env!("CARGO_PKG_VERSION"));
}
}
Loading