Forward-merge release/26.08 into main - #2350
Merged
Merged
Conversation
Fixes a bug in IVF-Flat and IVF-SQ `extend()` where a list could receive new vectors but keep its old logical `list::size`. The issue happens when extending a list that already has enough allocated capacity. Interleaved IVF list storage may be padded, so the old copy extent can be larger than the old logical size. Example: ```text old logical size: 100 old padded copy size: 128 new logical size: 120 ``` Previously, `resize_list()` received only the padded value, `128`, and used it both for copying old storage and for deciding whether `list::size` needed to be updated. It checked `120 <= 128`, skipped the update, and left `list::size == 100` even though new vectors were inserted up to `120`. This stale size can break the shared-list / copy-on-write logic in later extends and corrupt search results. ## Fix Update the `make_list_extents` in IVF-Flat and IVF-SQ to round up the list extents on creation, so that the extents always carry the "physical" size, then remove the rounding up from other places, so that the `list::size` value is always the "logical" size. This mirrors the current IVF-PQ approach. ## Tests Added regression tests for: ```text IVF-Flat repeated extend from a shared base index with enough existing capacity IVF-SQ in-place extend with enough existing capacity ``` Authors: - https://github.com/qwertyforce - Artem M. Chirkin (https://github.com/achirkin) - Tamas Bela Feher (https://github.com/tfeher) Approvers: - Tamas Bela Feher (https://github.com/tfeher) - https://github.com/huuanhhuyn URL: #2297
Contributor
Author
|
SUCCESS - forward-merge complete. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forward-merge triggered by push to release/26.08 that creates a PR to keep main up-to-date. If this PR is unable to be immediately merged due to conflicts, it will remain open for the team to manually merge. See forward-merger docs for more info.