Add Spectrum-X IPv6 CIDRPool generation - #154
Merged
Merged
Conversation
Generate the standard guide-based IPv6 host-to-leaf layout while preserving existing IPv4 output. Render family-specific NV-IPAM settings and routes across all Spectrum-X RA profiles, with allocator, renderer, and documentation coverage. Signed-off-by: Alexander Maslennikov <amaslennikov@nvidia.com>
Greptile SummaryThe PR adds topology-driven Spectrum-X IPv6 CIDRPool generation while preserving existing IPv4 output.
Confidence Score: 5/5The PR appears safe to merge; the new IPv6 allocation paths are validated and tested, and the existing IPv4 rendering contract remains intact. Supported topology fields are range-checked before address construction, generated prefixes are canonicalized, route and pool widths follow the documented plane modes, and templates receive explicit settings for both address families without changing IPv4 values. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart LR
A[Topology JSON] --> B[Normalize host-to-leaf links]
B --> C{IP version}
C -->|IPv4| D[Generate per-node /31 allocations]
C -->|IPv6| E[Encode plane rail pod SU host]
E --> F[Generate per-node /64 allocations]
D --> G[Group by rail or rail-plane]
F --> G
G --> H[Build CIDRPool settings and routes]
H --> I[Render Spectrum-X profile manifests]
Reviews (1): Last reviewed commit: "Add Spectrum-X IPv6 CIDRPool generation" | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fd02:00PP:RRDD:SSHH::peer/64static allocations, gateway/exclusion index2,/40pools, and plane-aware/32or/24routes in all Spectrum-X RA profilesThe current topology contract supplies plane, rail, pod, SU, and host indices, so this implements the standard addressing layout from the Spectrum-X deployment guide. Alternative platform-specific layouts that require additional topology fields remain out of scope.
Testing
go test -v -race -count=1 ./...make buildmake build-allgo run github.com/golangci/golangci-lint/v2/cmd/golangci-lint@v2.11.0 run ./...mkdocs build --strict