Skip to content

Split profile render tests by fabric - #156

Closed
almaslennikov wants to merge 1 commit into
mainfrom
test/fabric-profile-suites
Closed

Split profile render tests by fabric#156
almaslennikov wants to merge 1 commit into
mainfrom
test/fabric-profile-suites

Conversation

@almaslennikov

Copy link
Copy Markdown
Collaborator

Summary

  • group profile-render regression coverage under stable Ethernet and InfiniBand Go subtest paths
  • add make test-ethernet and make test-infiniband entry points
  • keep make test and go test ./... unchanged so both fabrics and common tests run by default
  • cover host-device rendering under both Ethernet and InfiniBand while retaining Spectrum-X and namespace checks in the Ethernet suite
  • document the selectors in README and CONTRIBUTING

This is a follow-up to #155, which merged while this addition was being prepared.

Why named subtests

Go build tags exclude files during compilation and make the all-by-default behavior awkward. Named subtests use the standard go test -run selector while preserving the normal unfiltered suite.

Validation

  • make test-ethernet
  • make test-infiniband
  • go test -race -count=1 ./...
  • CGO_ENABLED=0 go build ./...
  • CGO_ENABLED=0 go vet ./...
  • golangci-lint v2.11 run ./...
  • git diff --check

Group Ethernet and InfiniBand rendering coverage under stable Go subtest paths so either fabric can run independently while the default suite continues to run both.

Signed-off-by: Alexander Maslennikov <amaslennikov@nvidia.com>
@greptile-apps

greptile-apps Bot commented Aug 4, 2026

Copy link
Copy Markdown

Greptile Summary

The PR reorganizes profile-render regression tests beneath stable Ethernet and InfiniBand subtest paths without changing the default full suite.

  • Adds fabric-specific Make targets using Go subtest selectors.
  • Expands host-device rendering coverage to both fabrics.
  • Keeps Spectrum-X and namespace rendering checks in the Ethernet suite.
  • Documents full-suite and fabric-specific test commands.

Confidence Score: 5/5

The PR appears safe to merge with no actionable defects identified.

The new selectors match the named fabric subtrees, prior profile-render scenarios remain in the default suite, and the restructuring does not alter production behavior.

Important Files Changed

Filename Overview
pkg/networkoperatorplugin/sriov_render_test.go Reorganizes existing rendering regressions by fabric while retaining prior default coverage and adding InfiniBand host-device cases.
Makefile Adds correctly escaped selectors for running either fabric subtree independently.
README.md Documents the new targeted test commands and confirms unfiltered tests still run all suites.
CONTRIBUTING.md Adds contributor guidance for targeted profile-render testing while preserving the required full-suite check.

Reviews (1): Last reviewed commit: "Split profile render tests by fabric" | Re-trigger Greptile

@almaslennikov
almaslennikov deleted the test/fabric-profile-suites branch August 5, 2026 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant