Split profile render tests by fabric - #156
Closed
almaslennikov wants to merge 1 commit into
Closed
Conversation
Group Ethernet and InfiniBand rendering coverage under stable Go subtest paths so either fabric can run independently while the default suite continues to run both. Signed-off-by: Alexander Maslennikov <amaslennikov@nvidia.com>
Greptile SummaryThe PR reorganizes profile-render regression tests beneath stable Ethernet and InfiniBand subtest paths without changing the default full suite.
Confidence Score: 5/5The PR appears safe to merge with no actionable defects identified. The new selectors match the named fabric subtrees, prior profile-render scenarios remain in the default suite, and the restructuring does not alter production behavior. Important Files Changed
Reviews (1): Last reviewed commit: "Split profile render tests by fabric" | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EthernetandInfiniBandGo subtest pathsmake test-ethernetandmake test-infinibandentry pointsmake testandgo test ./...unchanged so both fabrics and common tests run by defaultThis is a follow-up to #155, which merged while this addition was being prepared.
Why named subtests
Go build tags exclude files during compilation and make the all-by-default behavior awkward. Named subtests use the standard
go test -runselector while preserving the normal unfiltered suite.Validation
make test-ethernetmake test-infinibandgo test -race -count=1 ./...CGO_ENABLED=0 go build ./...CGO_ENABLED=0 go vet ./...golangci-lint v2.11 run ./...git diff --check