Skip to content

Restrict cherry-pick comments to trusted users#403

Open
fallintoplace wants to merge 1 commit into
NVIDIA:mainfrom
fallintoplace:fix/cherrypick-comment-auth
Open

Restrict cherry-pick comments to trusted users#403
fallintoplace wants to merge 1 commit into
NVIDIA:mainfrom
fallintoplace:fix/cherrypick-comment-auth

Conversation

@fallintoplace

Copy link
Copy Markdown

Summary

  • require /cherry-pick issue comments to come from OWNER, MEMBER, or COLLABORATOR users
  • keep the same check in the comment script as a second guard
  • move workflow permissions from the workflow default to the jobs that need them

Why

The cherry-pick workflow listens to issue comments and can add labels, push backport branches, and open PRs. Before this change, any commenter could trigger the label path by starting a PR comment with /cherry-pick.

Validation

  • node -c .github/scripts/add-labels-from-comment.js
  • mocked unauthorized comment run returns before GitHub write calls
  • git diff --check

@copy-pr-bot

copy-pr-bot Bot commented Jun 14, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

Signed-off-by: Minh Vu <vuhoangminh97@gmail.com>
@fallintoplace fallintoplace force-pushed the fix/cherrypick-comment-auth branch from 6ed6d40 to b9187d1 Compare June 14, 2026 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant