fix: 🐛[BUG]: Docs rendering issues in generated API pages#101
Open
arnavnagzirkar wants to merge 2 commits into
Open
fix: 🐛[BUG]: Docs rendering issues in generated API pages#101arnavnagzirkar wants to merge 2 commits into
arnavnagzirkar wants to merge 2 commits into
Conversation
Contributor
Greptile SummaryThis PR fixes Sphinx rendering of the ASCII store-layout trees in the
Important Files Changed
Reviews (4): Last reviewed commit: "Merge branch 'main' into fix-98" | Re-trigger Greptile |
Fixes NVIDIA#98 Signed-off-by: Arnav Nagzirkar <113314200+arnavnagzirkar@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the Sphinx rendering of the Zarr store layout ASCII trees in the
AtomicDataZarrWriterandAtomicDataZarrReaderdocstrings. The trees now render as literal code blocks in the generated API docs instead of collapsing into a single paragraph.Root Cause
The Zarr store layout ASCII tree in the docstrings for
AtomicDataZarrWriterandAtomicDataZarrReaderwas written as plain indented text directly after a colon. In reStructuredText (used by Sphinx), plain indented text does not preserve whitespace, so it collapses into ordinary paragraph text, breaking the tree structure.Change Made
File:
nvalchemi/data/datapipes/backends/zarr.pyAdded
.. code-block:: textdirectives (with a blank line before and after the directive, and the tree content indented under it) for both affected docstring sections:AtomicDataZarrWriterdocstring (~line 276): wrapped the store layout tree in.. code-block:: textAtomicDataZarrReaderdocstring (~line 1194): wrapped the store layout tree in.. code-block:: textThis ensures Sphinx renders the ASCII tree as a literal/code block, preserving indentation and line structure.
Issue
Fixes #98
Issue URL: #98
Changes
Testing
AI Assistance Disclosure
This pull request was prepared with the assistance of AI coding tools (GitHub Copilot). The change has been read, understood, and is owned by the human contributor submitting it, who will respond to review feedback.