fix(metadata): correct NeMoClaw → NemoClaw product casing#292
Merged
Conversation
The marketplace product enum used 'NeMoClaw' (capital M), but the canonical product name is 'NemoClaw' everywhere it is defined (components.d/nemoclaw.yml, README, docs, and the skill's own SKILL.md/skill-card/evals). The generator stamps product.primary from this enum, so the typo was propagating into auto-generated metadata.json (flagged on #290). Fix the enum and the cosmetic plugins.d comment so the next regeneration emits the correct casing. Signed-off-by: Moshe Abramovitch <257371078+mosheabr@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Other context (for non-onboarding PRs)
Fixes the
product.primarycasing flagged by @rjensenNV on #290.Root cause: the marketplace product enum in
metadata.schema.jsonlistedNeMoClaw(capital M). The canonical product name isNemoClaweverywhere it is actually defined —components.d/nemoclaw.yml,README.md,docs/index.mdx, and the skill's ownSKILL.md/skill-card.md/evals.json/BENCHMARK.md. Because the metadata generator stampsproduct.primaryfrom this enum, the typo was propagating into the auto-generatedmetadata.json(visible on #290).Change:
.github/scripts/marketplace/metadata.schema.json— enumNeMoClaw→NemoClawplugins.d/nvidia-skills.yml— cosmetic comment# NeMoClaw→# NemoClawAfter this merges and the metadata regenerates,
nemoclaw-user-guidewill carryproduct.primary: "NemoClaw". #290 should be regenerated/closed in favor of the corrected output.All PRs