Fused algorithm for distributed DISCO#214
Merged
Merged
Conversation
…ted conv tests which do not fire yet because we need to make our routines autocastable
bonevbs
previously approved these changes
Jun 9, 2026
bonevbs
left a comment
bonevbs
left a comment
Collaborator
There was a problem hiding this comment.
LGTM - Please extensively test it in distributed mode before merginhg
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This MR adds a fused algorithm for distributed DISCO which is more memory efficient than the older ring algorithm and also 15x faster. I removed the ring algorithm and the API is not the same for serial and distributed DISCO.