Skip to content

Fix basis norm standard in distributed DISCO#215

Merged
azrael417 merged 2 commits into
mainfrom
bbonev/distributed-discrepancies
Jun 11, 2026
Merged

Fix basis norm standard in distributed DISCO#215
azrael417 merged 2 commits into
mainfrom
bbonev/distributed-discrepancies

Conversation

@bonevbs

@bonevbs bonevbs commented Jun 11, 2026

Copy link
Copy Markdown
Collaborator

resolving discrepancy in the default parameters between distributed and sequential DISCO implementations

@bonevbs bonevbs requested a review from azrael417 June 11, 2026 14:57
@bonevbs bonevbs self-assigned this Jun 11, 2026

@azrael417 azrael417 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add that change to the changeling since it is backwards compatible breaking.

@bonevbs bonevbs requested a review from azrael417 June 11, 2026 15:04

@azrael417 azrael417 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@azrael417 azrael417 merged commit a9ccb0e into main Jun 11, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants