Skip to content

C++-20 Compliance #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jwaldrop107 merged 3 commits into from
Nov 19, 2025
Merged

C++-20 Compliance #225

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1b4a322
C++-20 changes
jwaldrop107 Nov 19, 2025
776f93a
Update GHA PR workflow compilers
jwaldrop107 Nov 19, 2025
3f5383c
update GHA workflow compilers
jwaldrop107 Nov 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/pull_request.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,10 +32,10 @@ jobs:
test_library:
uses: NWChemEx/.github/.github/workflows/test_nwx_library.yaml@master
with:
compilers: '["gcc-11", "clang-14"]'
compilers: '["gcc-14", "clang-19"]'

test_library_with_sigma:
uses: NWChemEx/.github/.github/workflows/test_nwx_library.yaml@master
with:
compilers: '["gcc-11", "clang-14"]'
compilers: '["gcc-14", "clang-19"]'
repo_toolchain: ".github/enable_sigma.cmake"
1 change: 1 addition & 0 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ include(cmake/get_nwx_cmake.cmake)
#Sets the version to whatever git thinks it is
include(get_version_from_git)
get_version_from_git(tensorwrapper_version "${CMAKE_CURRENT_LIST_DIR}")
set(CMAKE_CXX_STANDARD 20)
project(tensorwrapper VERSION "${tensorwrapper_version}" LANGUAGES CXX)

include(nwx_versions)
Expand Down
2 changes: 1 addition & 1 deletion include/tensorwrapper/shape/smooth_view.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@ class SmoothView {
*
* @throw None No throw guarantee.
*/
bool operator==(const SmoothView<const SmoothType>& rhs) const noexcept;
bool operator==(const SmoothView& rhs) const noexcept;

/** @brief Is *this different from @p rhs?
*
Expand Down
5 changes: 2 additions & 3 deletions src/tensorwrapper/shape/smooth_view.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,11 +70,10 @@ void SMOOTH_VIEW::swap(SmoothView& rhs) noexcept {
}

TPARAMS
bool SMOOTH_VIEW::operator==(
const SmoothView<const SmoothType>& rhs) const noexcept {
bool SMOOTH_VIEW::operator==(const SmoothView<SmoothType>& rhs) const noexcept {
if(has_pimpl_() != rhs.has_pimpl_()) return false;
if(!has_pimpl_()) return true;
return m_pimpl_->as_const()->are_equal(*rhs.m_pimpl_);
return m_pimpl_->are_equal(*rhs.m_pimpl_);
}

TPARAMS
Expand Down