Flexible manifest input - #516
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #516 +/- ##
==========================================
- Coverage 63.55% 63.54% -0.02%
==========================================
Files 78 78
Lines 7365 7367 +2
Branches 741 741
==========================================
Hits 4681 4681
- Misses 2532 2533 +1
- Partials 152 153 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends extraction-mode collection manifest handling so users can pass either a single manifest path or multiple manifest paths (optionally with glob patterns), enabling batched extraction runs across arbitrary jurisdiction sets.
Changes:
- Added
load_collection_manifest_jurisdictions()to load and merge jurisdiction entries from one or more manifest files and to resolve persisted document paths when loading manifests. - Updated the extraction coordinator workflow to use the new jurisdictions loader instead of loading a single manifest dict.
- Added unit tests covering manifest input variants (string vs
Path, relative vs absolute, globbed vs explicit, single vs list) and shard-path resolution.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tests/python/unit/pipeline/test_pipeline_collection_persistence.py | Adds unit tests for multi-manifest inputs, wildcard support, and path resolution behavior. |
| compass/pipeline/data_classes.py | Updates request docstrings to describe list/glob-capable collection_manifest_fp. |
| compass/pipeline/coordinator.py | Switches extraction-mode manifest loading to the new multi-manifest jurisdictions loader. |
| compass/pipeline/collection/persistence.py | Implements multi-manifest jurisdictions loading and enables path resolution when loading manifests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow user to specify multiple collection manifest fp's, possible containing wildcards. This allows arbitrary jurisdiction extraction runs on batched collections.