Skip to content

Flexible manifest input - #516

Merged
ppinchuk merged 13 commits into
mainfrom
pp/flex_manifest_input
Aug 4, 2026
Merged

Flexible manifest input#516
ppinchuk merged 13 commits into
mainfrom
pp/flex_manifest_input

Conversation

@ppinchuk

@ppinchuk ppinchuk commented Aug 4, 2026

Copy link
Copy Markdown
Collaborator

Allow user to specify multiple collection manifest fp's, possible containing wildcards. This allows arbitrary jurisdiction extraction runs on batched collections.

@ppinchuk ppinchuk self-assigned this Aug 4, 2026
@ppinchuk
ppinchuk requested a review from castelao as a code owner August 4, 2026 01:06
Copilot AI review requested due to automatic review settings August 4, 2026 01:06
@ppinchuk ppinchuk added enhancement Update to logic or general code improvements p-medium Priority: medium topic-python-general Issues/pull requests related to python labels Aug 4, 2026
@codecov-commenter

codecov-commenter commented Aug 4, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 63.54%. Comparing base (8b2418f) to head (2c5f1d5).

Files with missing lines Patch % Lines
compass/pipeline/coordinator.py 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #516      +/-   ##
==========================================
- Coverage   63.55%   63.54%   -0.02%     
==========================================
  Files          78       78              
  Lines        7365     7367       +2     
  Branches      741      741              
==========================================
  Hits         4681     4681              
- Misses       2532     2533       +1     
- Partials      152      153       +1     
Flag Coverage Δ
unittests 63.54% <83.33%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR extends extraction-mode collection manifest handling so users can pass either a single manifest path or multiple manifest paths (optionally with glob patterns), enabling batched extraction runs across arbitrary jurisdiction sets.

Changes:

  • Added load_collection_manifest_jurisdictions() to load and merge jurisdiction entries from one or more manifest files and to resolve persisted document paths when loading manifests.
  • Updated the extraction coordinator workflow to use the new jurisdictions loader instead of loading a single manifest dict.
  • Added unit tests covering manifest input variants (string vs Path, relative vs absolute, globbed vs explicit, single vs list) and shard-path resolution.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
tests/python/unit/pipeline/test_pipeline_collection_persistence.py Adds unit tests for multi-manifest inputs, wildcard support, and path resolution behavior.
compass/pipeline/data_classes.py Updates request docstrings to describe list/glob-capable collection_manifest_fp.
compass/pipeline/coordinator.py Switches extraction-mode manifest loading to the new multi-manifest jurisdictions loader.
compass/pipeline/collection/persistence.py Implements multi-manifest jurisdictions loading and enables path resolution when loading manifests.

Comment thread compass/pipeline/collection/persistence.py
Comment thread compass/pipeline/coordinator.py Outdated
@ppinchuk
ppinchuk merged commit 31d7bec into main Aug 4, 2026
22 checks passed
@ppinchuk
ppinchuk deleted the pp/flex_manifest_input branch August 4, 2026 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Update to logic or general code improvements p-medium Priority: medium topic-python-general Issues/pull requests related to python

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants