Make sure text splitter is used even for PDF's - #520
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes an edge case in raw_pages_from_doc where PDF content represented as an MDDocument (with attrs["doc_type"] == "pdf") could bypass text splitting and allow an oversized “page” through to downstream processing.
Changes:
- Update
raw_pages_from_docto treat only realPDFDocumentinstances as PDFs (avoidingdoc_type-only detection for this path) and add a one-page PDF split failsafe. - Add unit tests covering oversized vs. within-budget behavior for both
MDDocumentandPDFDocumentinputs marked as PDF.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
compass/utilities/parsing.py |
Adjusts PDF/raw-page handling to ensure text splitting is applied in the problematic scenario. |
tests/python/unit/utilities/test_utilities_parsing.py |
Adds regression tests ensuring oversized PDF-like raw pages are split and within-budget pages are preserved. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #520 +/- ##
==========================================
+ Coverage 63.60% 63.85% +0.24%
==========================================
Files 78 78
Lines 7430 7437 +7
Branches 754 755 +1
==========================================
+ Hits 4726 4749 +23
+ Misses 2546 2528 -18
- Partials 158 160 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing a bug that sometimes let a giant page through if it was a PDF document that was parsed via MD