Adding an electrical thermal energy storage model and size optimizer - #810
Open
bayc wants to merge 34 commits into
Open
Adding an electrical thermal energy storage model and size optimizer#810bayc wants to merge 34 commits into
bayc wants to merge 34 commits into
Conversation
…into feature/heat_exchanger
…ate to latest control format
49 tasks
bayc
marked this pull request as ready for review
August 6, 2026 18:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding an electric Thermal Energy Storage Model
This PR adds and electric thermal energy storage (ETES) model, along with code to optimize the size of the ETES.
Review on implementation and structure would be very appreciated.
The docs will be updated after the first round of review is completed.
The included example is not meant to be final, but meant to showcase the performance of the ETES as as standalone technology. This example will be replaced with an integrated example showcasing a full heat component system in a future PR.
Section 1: Type of Contribution
Section 2: Draft PR Checklist
TODO:
Type of Reviewer Feedback Requested (on Draft PR)
Structural feedback:
Implementation feedback:
Other feedback:
Section 3: General PR Checklist
docs/files are up-to-date, or added when necessaryCHANGELOG.md"A complete thought. [PR XYZ]((https://github.com/NatLabRockies/H2Integrate/pull/XYZ)", where
XYZshould be replaced with the actual number.Section 4: Related Issues
Section 5: Impacted Areas of the Software
Section 5.1: New Files
storage/heat/etes.pystorage/heat/etes_cost_model.pystorage/heat/etes_milp.pystorage/heat/test/test_etes.pystorage/heat/test/test_etes_cost_model.pystorage/heat/test/test_etes_milp.pySection 5.2: Modified Files
path/to/file.extensionmethod1: What and why something was changed in one sentence or less.Section 6: Additional Supporting Information
Section 7: Test Results, if applicable
Section 8 (Optional): New Model Checklist
docs/developer_guide/coding_guidelines.mdattrsclass to define theConfigto load in attributes for the modelBaseConfigorCostModelBaseConfiginitialize()method,setup()method,compute()methodCostModelBaseClasssupported_models.pytest_all_examples.pydocs/user_guide/model_overview.mddocs/section<model_name>.mdis added to the_toc.ymlgenerate_class_hierarchy.pyto update the class hierarchy diagram indocs/developer_guide/class_structure.md