Skip to content

Remove remaining HOPP integration and references - #827

Draft
johnjasa wants to merge 15 commits into
NatLabRockies:developfrom
johnjasa:fully_remove_hopp
Draft

Remove remaining HOPP integration and references#827
johnjasa wants to merge 15 commits into
NatLabRockies:developfrom
johnjasa:fully_remove_hopp

Conversation

@johnjasa

@johnjasa johnjasa commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator

Remove remaining HOPP integration and references

This PR builds upon #825 and #826; those should be merged in before this one.

This PR removes remaining HOPP integration from H2Integrate and migrates the last active
HOPP-backed example path to native H2I components.

Summary of changes:

  1. Remove the hopp dependency from the project dependency stack.
  2. Remove HOPP component registration and related model-assembly logic.
  3. Remove HOPP converter modules and HOPP-specific tests.
  4. Replace example 25 sizing mode inputs to use a native electricity feedstock source.
  5. Remove all HOPP references from active docs, templates, and example narratives.
  6. Update tests/imports that relied on HOPP utility functions or constants.

Section 1: Type of Contribution

  • Feature Enhancement
    • Framework
    • New Model
    • Updated Model
    • Tools/Utilities
    • Other (please describe):
  • Bug Fix
  • Documentation Update
  • CI Changes
  • Other (please describe):

Section 2: Draft PR Checklist

  • Open draft PR
  • Describe the feature that will be added
  • Fill out TODO list steps
  • Describe requested feedback from reviewers on draft PR
  • Complete Section 8: New Model Checklist (if applicable)

TODO:

  • Remove HOPP dependency and model registration
  • Replace remaining HOPP usage in examples/tests with native H2I patterns

Type of Reviewer Feedback Requested (on Draft PR)

Structural feedback:
Confirm that removing the HOPP converter package does not conflict with any planned near-term work.

Section 3: General PR Checklist

  • PR description thoroughly describes the new feature, bug fix, etc.
  • Added tests for new functionality or bug fixes
  • Tests pass (If not, and this is expected, please elaborate in the Section 6: Test Results)
  • Documentation
    • Docstrings are up-to-date
    • Related docs/ files are up-to-date, or added when necessary
    • Documentation has been rebuilt successfully
    • Examples have been updated (if applicable)
  • CHANGELOG.md
    • At least one complete sentence has been provided to describe the changes made in this PR
    • After the above, a hyperlink has been provided to the PR using the following format:
      "A complete thought. [PR XYZ]((https://github.com/NatLabRockies/H2Integrate/pull/XYZ)", where
      XYZ should be replaced with the actual number.

Section 4: Related Issues

Fully addresses #824

Section 5: Impacted Areas of the Software

Section 5.1: New Files

N/A

Section 5.2: Modified Files

  • pyproject.toml
    • Remove hopp>=3.3.0 from dependencies.
  • h2integrate/core/supported_models.py
  • h2integrate/core/h2integrate_model.py
  • examples/25_sizing_modes/tech_config.yaml
  • examples/25_sizing_modes/plant_config.yaml
  • examples/25_sizing_modes/run_size_modes.py
  • h2integrate/converters/hydrogen/test/test_size_modes.py
  • h2integrate/core/test/test_utilities.py
  • h2integrate/tools/test/test_profast_tools.py
  • h2integrate/converters/wind/test/conftest.py
  • h2integrate/resource/utilities/test/conftest.py
  • docs/intro.md
  • docs/getting_started/expected_user_knowledge.md
    • Remove HOPP from dependency knowledge list.
  • docs/developer_guide/adding_a_new_technology.md
    • Replace HOPP wrapper references with current native component guidance.
  • docs/user_guide/model_overview.md
    • Remove HOPP model section.

Deleted files:

  • h2integrate/converters/hopp/hopp_mgmt.py
  • h2integrate/converters/hopp/hopp_wrapper.py
  • h2integrate/converters/hopp/__init__.py
  • h2integrate/converters/hopp/test/test_hopp_caching.py
  • h2integrate/converters/hopp/test/conftest.py
  • h2integrate/tools/h2integrate_sim_file_utils.py
  • examples/25_sizing_modes/tech_inputs/hopp_config_tx.yaml
  • examples/11_hybrid_energy_plant/tech_inputs/hopp_config.yaml

Section 6: Additional Supporting Information

This PR is intentionally broad and removes remaining references in active source and documentation
to keep the repository aligned with native H2I modeling patterns.

Section 7: Test Results, if applicable

Section 8 (Optional): New Model Checklist

N/A

@johnjasa johnjasa changed the title Fully remove hopp Remove remaining HOPP integration and references Aug 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant