Remove remaining HOPP integration and references - #827
Draft
johnjasa wants to merge 15 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove remaining HOPP integration and references
This PR builds upon #825 and #826; those should be merged in before this one.
This PR removes remaining HOPP integration from H2Integrate and migrates the last active
HOPP-backed example path to native H2I components.
Summary of changes:
hoppdependency from the project dependency stack.Section 1: Type of Contribution
Section 2: Draft PR Checklist
TODO:
Type of Reviewer Feedback Requested (on Draft PR)
Structural feedback:
Confirm that removing the HOPP converter package does not conflict with any planned near-term work.
Section 3: General PR Checklist
docs/files are up-to-date, or added when necessaryCHANGELOG.md"A complete thought. [PR XYZ]((https://github.com/NatLabRockies/H2Integrate/pull/XYZ)", where
XYZshould be replaced with the actual number.Section 4: Related Issues
Fully addresses #824
Section 5: Impacted Areas of the Software
Section 5.1: New Files
N/A
Section 5.2: Modified Files
pyproject.tomlhopp>=3.3.0from dependencies.h2integrate/core/supported_models.pyh2integrate/core/h2integrate_model.pyexamples/25_sizing_modes/tech_config.yamlexamples/25_sizing_modes/plant_config.yamlexamples/25_sizing_modes/run_size_modes.pyh2integrate/converters/hydrogen/test/test_size_modes.pyh2integrate/core/test/test_utilities.pyh2integrate/tools/test/test_profast_tools.pyh2integrate/converters/wind/test/conftest.pyh2integrate/resource/utilities/test/conftest.pydocs/intro.mddocs/getting_started/expected_user_knowledge.mddocs/developer_guide/adding_a_new_technology.mddocs/user_guide/model_overview.mdDeleted files:
h2integrate/converters/hopp/hopp_mgmt.pyh2integrate/converters/hopp/hopp_wrapper.pyh2integrate/converters/hopp/__init__.pyh2integrate/converters/hopp/test/test_hopp_caching.pyh2integrate/converters/hopp/test/conftest.pyh2integrate/tools/h2integrate_sim_file_utils.pyexamples/25_sizing_modes/tech_inputs/hopp_config_tx.yamlexamples/11_hybrid_energy_plant/tech_inputs/hopp_config.yamlSection 6: Additional Supporting Information
This PR is intentionally broad and removes remaining references in active source and documentation
to keep the repository aligned with native H2I modeling patterns.
Section 7: Test Results, if applicable
Section 8 (Optional): New Model Checklist
N/A