clean up index helpers and repo-level md files - #30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/strategy/traits.rsinto trait definitions (unchanged) and a newsrc/strategy/utils.rsholding the grid/index search helpers those traits'interpolateimpls call into, matching the split the in-progresscubic-splinebranch (CubicSpline #16) already landed independently.
find_nearest_index→locate_lower_index(public, no deprecation shim;pre-1.0, no stability guarantee yet),
step_index→locate_step_index,uniform_lower_index→locate_lower_index_uniform.locate_lower_indexitself instead of leaving ithand-inlined at every
Linearcall site. A first draft of Multi-channel ("shared-grid") interpolation support &DynInterpolator/DynInterpolatorMulti#19's multi-channelLinearoverride had reinvented this search without the clamp and panicked onextrapolated points; this closes that gap for good.
AxisLocation<T>+locate_axis, and uses them to replace the duplicatedclamp-array/
exact_indexlogic inLinear's 1D/2D/3Dinterpolate(the ND implkeeps its own dimensionality-reduction logic, just drops its now-redundant manual
clamp).
CHANGELOG→CHANGELOG.mdandLICENSE→LICENSE.mdso GitHub rendersthem instead of showing raw Markdown as plain text.
Test plan
cargo build --all-featurescargo test --all-features(68 unit tests, 15 doc tests, all passing)cargo clippy --all-features --all-targets(no new warnings vs.main)cargo fmt --check