ValidateError on grid length < 2 & variant cleanup - #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extrapolate::Enablewasn't selected, since the "at least 2 points" check only ran for that one setting.
Every bundled strategy actually needs 2+ points to bracket a query regardless of
extrapolation mode, so a 1-point dimension panicked on the first
interpolatecallinstead (integer underflow in the lower-bracket search, or an out-of-bounds index
right after it). Reproduced with
Interp1D::new(array![5.0], array![10.0], strategy::Linear, Extrapolate::Error).unwrap().interpolate(&[5.0]).InterpData::validate/InterpDataND::validate,turning that panic into a
ValidateError::InsufficientGridPointsat construction time.ValidateErrorvariants renamed for consistency, no longer fullsentences:
ExtrapolateSelection->InvalidExtrapolate,Monotonicity->NonMonotonic.EmptyGridis removed outright;InsufficientGridPointsnow coversboth the 0-point and 1-point cases with a single check.
README.md's error list updated to match.Test plan
test_insufficient_grid_pointscovering the exact panicscenario above
cargo build --all-featurescargo test --all-features(69 unit tests, 15 doc tests, all passing)cargo clippy --all-features --all-targets(clean)cargo fmt --check