Expose strategy::utils per-axis search helpers for custom strategies - #35
Merged
Conversation
exact_index, locate_step_index, locate_lower_index_uniform, check_uniform_grid, and AxisLocation/locate_axis were pub(crate), even though they're the actual primitives Linear/LinearUniform/Step/StepLower/ StepUpper are built from. Widen all to pub so custom strategies can reuse them instead of reimplementing from scratch. check_uniform_grid's error message hardcoded "LinearUniform:" regardless of caller; generalized now that other strategies can call it directly.
… docs Denied by CI's -D warnings on cargo doc: [Type](super::Type) is redundant when the label alone already resolves to the same intra-doc target.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #22:
exact_index,locate_step_index,locate_lower_index_uniform,check_uniform_grid, andAxisLocation/locate_axiswerepub(crate)even thoughthey're the actual primitives
Linear/LinearUniform/Step/StepLower/StepUpperare built from. Widened all to
pubso custom strategies can reuse them instead ofreimplementing from scratch.
check_uniform_grid's error message hardcoded"LinearUniform:"regardless ofcaller; generalized now that other strategies can call it directly.
Non-breaking, purely additive visibility change.
Test plan
cargo buildcargo test/cargo test --doccargo clippy --all-targetscargo fmt --checkcargo doc --no-deps