Skip to content

Add generic dispatch for ideal_type #1924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lgoettgens merged 1 commit into from
Dec 12, 2024
Merged

Add generic dispatch for ideal_type #1924

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/Ideal.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,3 +41,7 @@
iszero(I::Ideal) = all(iszero, gens(I))

base_ring_type(::Type{<:IdealSet{T}}) where T <: RingElement = parent_type(T)

# fundamental interface, to be documented
ideal_type(x) = ideal_type(typeof(x))
ideal_type(T::DataType) = throw(MethodError(ideal_type, (T,)))

Check warning on line 47 in src/Ideal.jl

View check run for this annotation

Codecov / codecov/patch

src/Ideal.jl#L46-L47 

Added lines #L46 - L47 were not covered by tests
1 change: 1 addition & 0 deletions src/exports.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,6 +260,7 @@ export hooklength
export howell_form
export howell_form_with_transformation
export ideal
export ideal_type
export identity_map
export identity_matrix
export image
Expand Down
Loading