Skip to content

Conversation

@fingolfin
Copy link
Member

@fingolfin fingolfin commented Dec 15, 2025

Based on Nemo's test/HeckeMiscLocalization-test.jl

As always (?), running conformance tests revealed a genuine bug (this time in is_unit(::LocalizedEuclideanRingElem)

Based on Nemo's test/HeckeMiscLocalization-test.jl
@fingolfin fingolfin changed the title Add test for LocalizedEuclideanRing LocalizedEuclideanRing: add tests, fix some bugs, run conformance tests Dec 15, 2025
@codecov
Copy link

codecov bot commented Dec 15, 2025

Codecov Report

❌ Patch coverage is 57.89474% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.46%. Comparing base (0eb3ed5) to head (3d2c79c).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
src/generic/Misc/Localization.jl 57.89% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2254      +/-   ##
==========================================
+ Coverage   88.07%   88.46%   +0.38%     
==========================================
  Files         126      126              
  Lines       31728    31994     +266     
==========================================
+ Hits        27946    28305     +359     
+ Misses       3782     3689      -93     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fingolfin fingolfin added this to the 0.48 milestone Dec 16, 2025
@fingolfin fingolfin mentioned this pull request Dec 16, 2025
@lgoettgens lgoettgens closed this Dec 17, 2025
@lgoettgens lgoettgens reopened this Dec 17, 2025
@lgoettgens lgoettgens enabled auto-merge (squash) December 17, 2025 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants