Skip to content

Simplify rand for UniversalPolyRing #2257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SoongNoonien wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Simplify rand for UniversalPolyRing #2257

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 3 additions & 35 deletions src/generic/UnivPoly.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -880,43 +880,11 @@ end
#
###############################################################################

RandomExtensions.maketype(S::AbstractAlgebra.UniversalPolyRing, _, _, _) = elem_type(S)

function RandomExtensions.make(S::AbstractAlgebra.UniversalPolyRing, term_range::AbstractUnitRange{Int},
exp_bound::AbstractUnitRange{Int}, vs...)
R = coefficient_ring(S)
if length(vs) == 1 && elem_type(R) == Random.gentype(vs[1])
Make(S, term_range, exp_bound, vs[1])
else
Make(S, term_range, exp_bound, make(R, vs...))
end
end

function rand(rng::AbstractRNG, sp::SamplerTrivial{<:Make4{
<:RingElement, <:AbstractAlgebra.UniversalPolyRing, <:AbstractUnitRange{Int}, <:AbstractUnitRange{Int}}})
S, term_range, exp_bound, v = sp[][1:end]
f = S()
g = gens(S)
R = coefficient_ring(S)
for i = 1:rand(rng, term_range)
term = S(1)
for j = 1:length(g)
term *= g[j]^rand(rng, exp_bound)
end
term *= rand(rng, v)
f += term
end
return f
function rand(rng::AbstractRNG, S::UniversalPolyRing, args...)
return UnivPoly(rand(rng, make(base_ring(S), args...)), S)
end

function rand(rng::AbstractRNG, S::AbstractAlgebra.UniversalPolyRing,
term_range::AbstractUnitRange{Int}, exp_bound::AbstractUnitRange{Int}, v...)
rand(rng, make(S, term_range, exp_bound, v...))
end

function rand(S::AbstractAlgebra.UniversalPolyRing, term_range, exp_bound, v...)
rand(Random.default_rng(), S, term_range, exp_bound, v...)
end
rand(S::UniversalPolyRing, args...) = rand(Random.default_rng(), S, args...)

###############################################################################
#
Expand Down
Loading