add support for PAY_PER_REQUEST BillingMode#72
Open
mgwilliams wants to merge 2 commits intoNerdWalletOSS:masterfrom
Open
add support for PAY_PER_REQUEST BillingMode#72mgwilliams wants to merge 2 commits intoNerdWalletOSS:masterfrom
mgwilliams wants to merge 2 commits intoNerdWalletOSS:masterfrom
Conversation
Author
|
@borgstrom It looks like the build failed due to no bump in version -- should I have opened the pull request to some other branch than master? Or are contributors expected to version bump? Or did I misunderstand the build failure? |
Contributor
|
Hi @mgwilliams, Sorry for the delay! I was out on vacation/traveling. Yes, can you please bump the version in |
borgstrom
reviewed
Aug 27, 2019
| stream False str The stream view type, either None or one of: | ||
| 'NEW_IMAGE'|'OLD_IMAGE'|'NEW_AND_OLD_IMAGES'|'KEYS_ONLY' | ||
|
|
||
| ========= ======== ==== =========== |
Contributor
There was a problem hiding this comment.
CI is complaining about malformed RST here:
Warning, treated as error:
/home/travis/build/NerdWalletOSS/dynamorm/dynamorm/table.py:docstring of dynamorm.table:13:Malformed table.
Text in column margin in table line 7.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.