Eta fix v2 electric boogaloo #1190
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dxqb
reviewed
Dec 6, 2025
|
|
||
| def _calculate_eta_string(self, train_progress: TrainProgress, max_step: int, max_epoch: int) -> str | None: | ||
| # Guard against None values before first progress callback | ||
| if self.start_time is None or self.session_start_epoch is None: |
Collaborator
There was a problem hiding this comment.
this can never happen. the function is only called immediatly after setting it to non-None
if you want have a logical check, an assert() would do that
Collaborator
as long as it's not accessing internals of GenericTrainer, I think it's safe at doesn't necessarily have to be tested with cloud or multi. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Round 2 of eta fix, hopefully this time not breaking cloud and multi-gpu. Need another to test cloud.