Skip to content

feat: enhancement in n/w dashboard and switch dashboard#4161

Merged
rahulguptajss merged 8 commits intomainfrom
hl_dash
Feb 25, 2026
Merged

feat: enhancement in n/w dashboard and switch dashboard#4161
rahulguptajss merged 8 commits intomainfrom
hl_dash

Conversation

@Hardikl
Copy link
Contributor

@Hardikl Hardikl commented Feb 23, 2026

No description provided.

@Hardikl Hardikl requested a review from cgrinds as a code owner February 23, 2026 09:23
Copilot AI review requested due to automatic review settings February 23, 2026 09:23
@cla-bot cla-bot bot added the cla-signed label Feb 23, 2026
@Hardikl Hardikl linked an issue Feb 23, 2026 that may be closed by this pull request
@Hardikl Hardikl marked this pull request as draft February 23, 2026 09:24
@Hardikl
Copy link
Contributor Author

Hardikl commented Feb 23, 2026

Found some issue with monitoring local cisco switches, might be transient one, I will convert PR to review after the validation against them.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enhances the cmode Grafana dashboards for network and switch visibility by adding additional NIC error series and expanding switch-port detail fields, alongside REST template label changes to expose those fields.

Changes:

  • Extend the switch dashboard table to include op_state, admin_state, is_isl, and type, and add corresponding field display mappings.
  • Add additional NIC TX/RX error queries to the network dashboard error panels.
  • Update the REST template for ethernet_switch_port to export admin_state and rename state to op_state (and update the LabelAgent mapping accordingly).

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
grafana/dashboards/cmode/switch.json Adds/renames switch-port status fields and new table column mappings/filters.
grafana/dashboards/cmode/network.json Adds additional NIC TX/RX error PromQL targets to existing error panels.
conf/rest/9.8.0/ethernet_switch_port.yaml Exposes new labels (admin_state, op_state) for the switch-port status metric.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Hardikl
Copy link
Contributor Author

Hardikl commented Feb 23, 2026

  1. Added nic_tx_errors in NICs Send Errors by Cluster panel and nic_rx_errors in NICs Receive Errors by Cluster panel in Ontap: Network dashboard.
image
  1. Added ISL, Type, Op status and updated Admin status.
image

@Hardikl Hardikl marked this pull request as ready for review February 23, 2026 14:08
Copilot AI review requested due to automatic review settings February 23, 2026 14:08
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings February 24, 2026 14:35
@Hardikl
Copy link
Contributor Author

Hardikl commented Feb 24, 2026

image

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@rahulguptajss rahulguptajss merged commit c67125d into main Feb 25, 2026
10 checks passed
@rahulguptajss rahulguptajss deleted the hl_dash branch February 25, 2026 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Network, Switch and Cisco Switch dashboard enhancement

4 participants