Skip to content

feat: Harvest should monitor fabric link status#4175

Merged
cgrinds merged 3 commits intomainfrom
cbg-fabric-link
Mar 4, 2026
Merged

feat: Harvest should monitor fabric link status#4175
cgrinds merged 3 commits intomainfrom
cbg-fabric-link

Conversation

@cgrinds
Copy link
Collaborator

@cgrinds cgrinds commented Mar 4, 2026

Thanks to dhirajmalkari for reporting!

Thanks to dhirajmalkari for reporting!
Copilot AI review requested due to automatic review settings March 4, 2026 14:47
@cla-bot cla-bot bot added the cla-signed label Mar 4, 2026
@cgrinds cgrinds linked an issue Mar 4, 2026 that may be closed by this pull request
Hardikl
Hardikl previously approved these changes Mar 4, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds FabricLink status awareness to the SnapMirror REST collection so Harvest can surface a derived “fabric link healthy” label alongside existing SnapMirror health signals.

Changes:

  • Extend the SnapMirror REST config to collect fl_status and export a new derived label fl_healthy.
  • Add plugin logic to derive fl_healthy from healthy and parsed fl_status.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
conf/rest/9.12.0/snapmirror.yaml Collects fl_status and exports fl_healthy as an instance label.
cmd/collectors/rest/plugins/snapmirror/snapmirror.go Computes and sets fl_healthy during SnapMirror plugin execution.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Thanks to dhirajmalkari for reporting!
Thanks to dhirajmalkari for reporting!
Copilot AI review requested due to automatic review settings March 4, 2026 15:21
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

@cgrinds cgrinds merged commit f97b070 into main Mar 4, 2026
14 checks passed
@cgrinds cgrinds deleted the cbg-fabric-link branch March 4, 2026 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ONTAP monitoring S3 Snapmirror relationships

3 participants