Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the ONTAP cDOT license collection/export and corresponding Grafana dashboard to treat serial_number as part of the license identity, preventing series collisions and improving table joins.
Changes:
- Export
serial_numberas aninstance_keyfor the RESTlicenseplugin (so it’s present on all license metric time series). - Update the cDOT license Grafana dashboard to include
serial_numberin theunique_idlabel join for license tables.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| grafana/dashboards/cmode/license.json | Includes serial_number in the unique_id label_join to correctly distinguish license rows in the table. |
| cmd/collectors/rest/plugins/license/license.go | Moves serial_number into instance_keys so it is exported on all license metric series (not just the _labels pseudo-metric). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Hardikl
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.