Gracefully handle failure in nkpacket_transport_tcp:start_link#8
Open
mritalian wants to merge 1 commit intoNetComposer:masterfrom
Open
Gracefully handle failure in nkpacket_transport_tcp:start_link#8mritalian wants to merge 1 commit intoNetComposer:masterfrom
mritalian wants to merge 1 commit intoNetComposer:masterfrom
Conversation
If a new connection fails to start for whatever reason, without this catch, it will tear down the entire service, including all other established connections. Change-Id: I9d109340ddf7818411dcfaec4452df85c389a82a
Member
|
Hi, thank you. I think it make sense. Could you please send it again against last version to avoid conflicts? I am not using this code now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a new connection fails to start for whatever reason, without this catch, it will tear down the entire service, including all other established connections.