Workaround for malicious/broken SIP-clients#52
Open
lemenkov wants to merge 1 commit intoNetComposer:masterfrom
Open
Workaround for malicious/broken SIP-clients#52lemenkov wants to merge 1 commit intoNetComposer:masterfrom
lemenkov wants to merge 1 commit intoNetComposer:masterfrom
Conversation
Some nasty SIP-clients sends only \n instead of \r\n. We shouldn't crash on these packets. Signed-off-by: Peter Lemenkov <lemenkov@gmail.com>
Member
|
Maybe we could add a global config options, and accept that optionally if you activate it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello All!
Some nasty SIP-clients sends only \n instead of \r\n (malicious SIP scanners). We shouldn't crash
on these packets.
Actually I'm not sure about how we should handle this. RFC 3261 states clearly that the only allowed line terminator is CRLF, however previous RFC 2543 does allows line endings with CR, LF, and CRLF. Also some people advise allowing CRLF, CR, and LF as a line delimiters when parsing incoming SIP packets (see http://www.networksorcery.com/enp/protocol/sip.htm).
What other thinks about this? Is it worth fixing at all?