update: regularModule add __doBuild function, and can assign __export info#12
Open
shhider wants to merge 1 commit intoNetEaseWD:masterfrom
Open
update: regularModule add __doBuild function, and can assign __export info#12shhider wants to merge 1 commit intoNetEaseWD:masterfrom
shhider wants to merge 1 commit intoNetEaseWD:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
现在的regularModule无法设置
__export属性,以指定子模块容器,即失去了私有模块的功能。本PR即添加该功能。添加过程中有考虑过允许regularModule子类直接在声明、或config方法中直接指定子模块容器。但根据Regular的生命周期,在config方法执行完后,才有初始化的DOM元素。因此只能在init方法以及之后进行。
然后看到regularModule的父类
_$$ModuleAbstract的代码,组合模块的逻辑在__onShow和__onRefresh时调用;而regularModule中__onShow和__onRefresh中先执行了父方法。因此使用时在__onShow和__onRefresh时指定也不行。所以只能放目光放在regularModule的
__build方法,并结合NEJ模块的风格,向regularModule子类提供了__doBuild方法,在该方法中可以指定子模块容器和其他开放信息(即__export)。具体逻辑可见代码。