Skip to content

Remove unused imports and improve code clarity #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Remove unused imports and improve code clarity #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ddf3e8f
Initial plan
Copilot Feb 17, 2026
4f893cd
Remove unused imports, dead code, and improve readability
Copilot Feb 17, 2026
c0e6fd3
Address code review feedback - simplify conditional
Copilot Feb 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions netqmpi/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
__version__ = "0.1.0"
1 change: 0 additions & 1 deletion netqmpi/runtime/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import argparse
import importlib
import subprocess
import sys
import os
import time
Expand Down
7 changes: 2 additions & 5 deletions netqmpi/sdk/communicator/communicator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,12 @@
from typing import List

import netqasm.sdk.toolbox
import numpy as np
from netqasm.sdk import EPRSocket, Qubit, set_qubit_state
from netqasm.sdk import EPRSocket, Qubit
from netqasm.sdk.classical_communication.broadcast_channel import BroadcastChannel
from netqasm.sdk.classical_communication.message import StructuredMessage
from netqasm.sdk.external import Socket
from netqasm.sdk.external import NetQASMConnection
from netqasm.sdk.toolbox import create_ghz
from netqasm.sdk.classical_communication.broadcast_channel import BroadcastChannel, BroadcastChannelBySockets

from netqmpi.sdk.primitives.collective.collective import CollectiveCommTeledata, CollectiveCommTelegate
from netqmpi.sdk.primitives.p2p import P2PCommTeledata
Expand Down Expand Up @@ -47,8 +46,6 @@ def __init__(self, rank, size, app_config):
# Get remote app names
remote_app_names = [self.__get_rank_name(i) for i in range(size) if i != rank]

# self.broadcast_channel = BroadcastChannelBySockets(self.__get_rank_name(rank), remote_app_names)

def __enter__(self):
self.connection.__enter__()
return self
Expand Down
6 changes: 4 additions & 2 deletions netqmpi/sdk/primitives/collective/collective.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,8 @@ def expose(communicator: "QMPICommunicator", qubits: List[Qubit], rank: int = 0)
bit = int(measure)

# If bit is 1, apply an X gate to the GHZ qubit
bit and communicator.ghz_qubit.X()
if bit:
communicator.ghz_qubit.X()
qubits.insert(0, communicator.ghz_qubit)

@staticmethod
Expand All @@ -186,7 +187,8 @@ def unexpose(communicator: "QMPICommunicator", rank: int = 0) -> None:
communicator.connection.flush()

# Compute AND of all bits
np.bitwise_and.reduce(bits) and communicator.ghz_qubit.Z()
if np.bitwise_and.reduce(bits):
communicator.ghz_qubit.Z()

else:
# Apply Hadamard gate to the GHZ qubit
Expand Down