Fix compile warnings in mantis-control-plane-client module#839
Open
sachinnn99 wants to merge 3 commits intoNetflix:masterfrom
Open
Fix compile warnings in mantis-control-plane-client module#839sachinnn99 wants to merge 3 commits intoNetflix:masterfrom
sachinnn99 wants to merge 3 commits intoNetflix:masterfrom
Conversation
Replace Func1, Func2, Action0, and Action1 anonymous class instances with lambda expressions in HttpUtility, ConditionalRetry, and MasterClientWrapper. Remove unused imports.
Use JacksonCodecs.pojo() as recommended by the @deprecated annotation on the JsonCodec constructor.
- Replace wildcard imports with specific imports in MantisMasterClientApi and MantisMasterGateway - Remove empty javadoc blocks with no descriptions - Use method references where applicable
sachinnn99
requested review from
Andyz26,
calvin681,
dtrager02,
fdc-ntflx,
hellolittlej and
james-lubin
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Comprehensive fix for compile warnings in the
mantis-control-plane-clientmodule.HttpUtility,ConditionalRetry, andMasterClientWrapperJsonCodecconstructor withJacksonCodecs.pojo()as recommended by the@DeprecatedannotationHttpRequest.getUri()withHttpRequest.uri()io.mantisrx.server.core.*) to specific imports inMantisMasterClientApiandMantisMasterGatewayHttpClientResponse::getStatus,HttpClientResponse::getContent)Addresses #389. PR #421 addressed only 2 of many warnings — this PR provides a more comprehensive fix.
Test plan
./gradlew :mantis-control-plane:mantis-control-plane-client:compileJavapasses./gradlew :mantis-control-plane:mantis-control-plane-client:testpasses