fix: wait for safeStorage availability before encrypt/decrypt#84
Merged
edospadoni merged 2 commits intomainfrom Jan 14, 2026
Merged
fix: wait for safeStorage availability before encrypt/decrypt#84edospadoni merged 2 commits intomainfrom
edospadoni merged 2 commits intomainfrom
Conversation
6539ec2 to
ab31bf9
Compare
tonyco97
approved these changes
Jan 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On Windows, the app sometimes fails to auto-login at startup. This happens because
safeStorage(which uses DPAPI on Windows) may not be immediately available when the system boots.The previous code called
safeStorage.encryptString()andsafeStorage.decryptString()without checking if encryption was available, causing silent failures.Solution
Added
waitForSafeStorage()helper method that:safeStorage.isEncryptionAvailable()before any encrypt/decrypt operationApplied this check to:
autoLogin(): waits for safeStorage before decrypting saved credentialssaveLoggedAccount(): waits for safeStorage before encrypting credentials to save