Skip to content

Conversation

@m-dilorenzi
Copy link
Collaborator

This pull request updates the network scanning functionality in the DNS/DHCP UI to restrict scans to interfaces with a /20 netmask or larger. It introduces new UI feedback to inform users when a network is too large to scan, updates the relevant props and interface definitions, and improves the scan button behavior. Additionally, it updates internationalization strings to reflect these changes.

Network scan restriction and UI feedback:

  • The scan network button is now disabled for interfaces with a netmask smaller than /20, and a tooltip explains the restriction to the user.
  • Added a new prop scanButtonDisabledNetworkTooLarge and updated the logic to control the scan button's disabled state and tooltip display.

Data and interface improvements:

  • The ScanInterface type now includes a netmask property, and the interface list is populated with this data from the backend.

Scan request improvements:

  • The scan request now sends both device and interface parameters to the backend for more precise operation. (ScanNetwork.vue)

Internationalization updates:

  • Updated English and Italian descriptions to clarify the scan restriction, and added a new message for the tooltip explaining the limitation.

Refs: NethServer/nethsecurity#1434

@m-dilorenzi m-dilorenzi requested a review from Tbaile January 28, 2026 12:00
@m-dilorenzi m-dilorenzi self-assigned this Jan 28, 2026
@m-dilorenzi m-dilorenzi marked this pull request as draft February 3, 2026 11:32
@m-dilorenzi
Copy link
Collaborator Author

Using the ip -j address command in the backend lets you handle interfaces that aren’t statically configured (ex. DHCP, OpenVPN tunnels, etc.), for which the netmask can’t be retrieved via UCI because it isn’t explicitly configured there. The backend will send the information scan_available for all networks (no more the netmask value), allowing you to avoid the error (by disabling the scan button) on all types of networks.

@m-dilorenzi m-dilorenzi marked this pull request as ready for review February 3, 2026 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

network scan fails when using very large subnets

2 participants