Snort: new bypass and allow home net configuration #1496
Merged
+134
−117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsanchietti
force-pushed
the
issue1381
branch
from
42805bb to
5db21f7
Compare
gsanchietti
changed the title
Tbaile
approved these changes
Feb 4, 2026
Collaborator
Tbaile
left a comment
Tbaile
left a comment
There was a problem hiding this comment.
Even checked that an update to latest version won't give us too many conflicts. Greenlighling it
filippocarletti
requested changes
Feb 4, 2026
Member
filippocarletti
left a comment
filippocarletti
left a comment
There was a problem hiding this comment.
The migration of the bypasses doesn’t work:
- before
snort.nfq.bypass_dst_v4='192.168.122.2,'
snort.nfq.bypass_src_v4='192.168.122.2,' '192.168.122.3,'
- after
snort.nfq.bypass_v4='192.168.122.2, 192.168.122.3,'
root@NethSec:~# nft list table inet snort
table inet snort {
set bypass_v4 {
type ipv4_addr
flags interval
elements = { 192.168.122.2 }
}
And the UI shows only one bypass with 192.168.122.3 in the description.
Unify logic: having 2 different bypass types can lead to wrong config The migration takes care of the following aspects: - merge dst and src bypass for both ipv4 and ipv6 - make sure to preserve descriptions with spaces - prevent bypass duplication based on IP (description of a duplicate is lost)
Allow users to specify and change the Snort home net: on some scenarios it could be useful also to add VPN networks
gsanchietti
force-pushed
the
issue1381
branch
from
d8952d0 to
99254c7
Compare
Member
Author
|
Major changes:
See also the related changes to the UI: NethServer/nethsecurity-ui#683 |
filippocarletti
approved these changes
Feb 4, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Fixes #1422
Implements #1381