Conversation
Member
|
@Amygos is this fix effective also for already provisioned instances? |
Amygos
approved these changes
May 16, 2024
Member
No, the fix will apply only on fresh module installations, or when the value of To avoid the first issue we can resume the work in the PR #19, so we can always set the correct value in the For the users already created on db, I would leave the old value of the filed. |
Contributor
Author
|
noobs question @Amygos, what is the purpose or the advantage of your solution ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the
userDisplayNameFieldin theconfigure-module/20configfile to use the "displayName" field instead of the "gecos" field.However
so in short it is valid only for first installation
NethServer/dev#6923