Feature/resampling mark #72
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rensicInstitute/scratch into feature/resampling_mark
…e/scratch into feature/resampling_mark
Diff CoverageDiff: origin/main..HEAD, staged and unstaged changes
Summary
packages/scratch-core/src/conversion/data_formats.pyLines 32-40 32 @property
33 def sampling_rate(self) -> float:
34 if self == MarkType.BREECH_FACE_IMPRESSION:
35 return 3.5e-6
! 36 return 1.5e-6
37
38
39 class CropType(Enum):
40 RECTANGLE = auto()packages/scratch-core/src/conversion/mark.pyLines 1-10 ! 1 from image_generation.data_formats import ScanImage
! 2 from conversion.data_formats import MarkType, CropType, MarkImage
3
4
! 5 def scan_image_to_mark(scan_image: ScanImage, mark_type: MarkType, crop_type: CropType):
! 6 return MarkImage(
7 scan_image=scan_image,
8 mark_type=mark_type,
9 crop_type=crop_type,
10 ) |
1 similar comment
Diff CoverageDiff: origin/main..HEAD, staged and unstaged changes
Summary
packages/scratch-core/src/conversion/data_formats.pyLines 32-40 32 @property
33 def sampling_rate(self) -> float:
34 if self == MarkType.BREECH_FACE_IMPRESSION:
35 return 3.5e-6
! 36 return 1.5e-6
37
38
39 class CropType(Enum):
40 RECTANGLE = auto()packages/scratch-core/src/conversion/mark.pyLines 1-10 ! 1 from image_generation.data_formats import ScanImage
! 2 from conversion.data_formats import MarkType, CropType, MarkImage
3
4
! 5 def scan_image_to_mark(scan_image: ScanImage, mark_type: MarkType, crop_type: CropType):
! 6 return MarkImage(
7 scan_image=scan_image,
8 mark_type=mark_type,
9 crop_type=crop_type,
10 ) |
Minimum allowed line rate is |
1 similar comment
Minimum allowed line rate is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a new object: MarkImage which is an ImageContainer like ScanImage, but with two additional features: the MarkType and CropType (which are also implemented). Then the resample function had to be refactored a little to allow for resampling of MarkImages.